Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menyoo Customs: Bike wheels are not being saved properly #447

Closed
metoxys opened this issue Dec 22, 2022 · 7 comments
Closed

Menyoo Customs: Bike wheels are not being saved properly #447

metoxys opened this issue Dec 22, 2022 · 7 comments

Comments

@metoxys
Copy link
Contributor

metoxys commented Dec 22, 2022

Reproduce: Customize bike, select different rims for front and rear wheel, save bike to file, spawn saved bike from file

Rim selected for the front wheel is on the rear wheel as well

@metoxys
Copy link
Contributor Author

metoxys commented Dec 22, 2022

Just for additional info, I am sure that this is a bug about saving bike wheels and not spawning them, because bikes I saved in earlier versions of Menyoo spawned fine with different rims

@itsjustcurtis
Copy link
Contributor

Entirely possible, recent changes to the save vehicle script may have messed with that slightly

@metoxys
Copy link
Contributor Author

metoxys commented Dec 22, 2022

Entirely possible, recent changes to the save vehicle script may have messed with that slightly

If it helps, according to my notes, in previous Menyoo versions, ID 23 is front rim, ID 24 is rear rim
EDIT: My hypothesis is that front wheel ID is being saved as both 23 and 24

@metoxys
Copy link
Contributor Author

metoxys commented Dec 23, 2022

image
@itsjustcurtis
Now, when customizing bike rear wheels, I can change the rim by pressing Enter, but the icon confirming which rim is on there is not changing when LSC style is turned off
Also the saving is not working just as before

@itsjustcurtis
Copy link
Contributor

I've come across this before, I think its an issue with how the menu is rendered. The saving of wheels is separate, I'll have a look at whats going on

@itsjustcurtis
Copy link
Contributor

image

Looking at the wheel indexes, the list actually skips a number of indexes, making it almost impossible to get the marker to show properly. This is going to take a lot of effort to make work properly by the looks of things.

@metoxys
Copy link
Contributor Author

metoxys commented Dec 24, 2022

Maybe my hardcoded wheel id list idea is not so crazy after all
Could be worth a shot, especially if it's only executed when an untampered wheel list is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants