2802.0 compatibility update and functionality #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch up to Master
- Fixed bug with menu colour display not showing for blue on RGB paints - Fixed spawn bug with amphibious vehicles when being recovered as saved vehicles - Added 2nd livery option for those that support it (Tornado Roof) - Added options to retain Dirt when repairing cars - Added hidden function to store and print carvariation colours for private use. Option is currently commented out.
Changes made to master were not copied into this before changes made
colours selected using index scroll did not save when navigating back. Issue should now be resolved
Disabled resets the currentop variable, causing the menus to reset to the top when users expect the option to be where they left it. No known consequences in testing are apparent as yet.
Supplement to fix for #427. Two additional versions were added to the list, throwing off the switch/case when applying the despawn global.
Fix for #427, added the new pointer and corrected some old game versions.
MAFINS
requested changes
Dec 20, 2022
There was a problem hiding this comment.
MenyooSP/Solution/source/Menu/Menu.cpp
Lines 847 to 850 in 67b943b
This is meant to keep the index of the currently selected item in bounds so it isn't off the screen (and hence is imperative to the functioning of some submenus). The only way it would reset to the first item would be if currentop or printingop becomes 0 or negative.
|
Do you know which submenus so I can test properly? This is the only way that I could think to fix the LSC issue. Unless I build a workaround in there to skip it if the sub isn't menyoo customs? |
|
Some major bugs found in testing. Closing until ready for resubmission |
Removed segment that forced selection of a carvariation colour instead of retaining selected colour from paint menus
put back removed code as potential fix for menu jump issue. Put special case to skip this segment for the modshop menu only.
Closed
Add fix for rgb paint scripts when number outside of 0-255 is used.
|
Has FiveM compatibility been updated with this as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a number of new functions, as well as significant fixes for old ones. Several issues fixed as noted in the commits. Version update to 1.7.3.