Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes ACV from shapash and fixes dependencies #505

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Removes ACV from shapash and fixes dependencies #505

merged 6 commits into from
Nov 2, 2023

Conversation

MLecardonnel
Copy link
Collaborator

Description

Removes ACV from shapash backends: #482
Fixes seaborn dependencies: #503
Fixes shap dependencies for tests with fake models

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • OS:Linux
  • Python version:3.9
  • Shapash version:2.3.7

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasBouche ThomasBouche merged commit 7d59855 into MAIF:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBouche ThomasBouche ThomasBouche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MLecardonnel @ThomasBouche