-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force a read of 'forcing' streams on init #10
Conversation
Previously, input files used as time-varying forcing failed to be read at the initial model time. This commit forces input streams with an input_interval set to a time duration to be forced to be read at the model initial time. They are read in the same we these "forcing" files are read during timestepping by using the most recent previous time level from the input file.
I tested this on Cori with the Humboldt Glacier r04 mesh and forcings. The code hangs before all input streams are read.
|
@trhille , thanks for testing this. Can you send me the path to the full log and the streams file used? |
/global/cscratch1/sd/trhille/Humboldt_1to10km_r04_20210617/m7/MIROC5/testPR10 |
The new functionality now works as expected for a simple test.
Testing after 6301c56 produced desired behavior and code did not hang. From log.landice.000.out: ` Finished reading 'initial_only' input streams.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing produces desired results. Ready to merge.
The ISMIP6 forcings are defined on July 1 of each year, and at one point, there was an issue with reading forcings requiring that the start time match the forcing time on init. That problem was fixed in MALI-Dev/E3SM#10 so we no longer need to start in the middle of the year to use the ISMIP6 forcing. To avoid confusion, I'm changing all tests to starrt on 2007-01-01. Also change all stream reference times to 2007-01-01. This is not necessary, because the default reference time of 0000-01-01 will yield the same results. But I'm changing it for explicitness. A minor conisderation is choosing a reference_time closer to the model clock time should provide a very small improvement to the cost of timekeeping operations related to i/o.
The ISMIP6 forcings are defined on July 1 of each year, and at one point, there was an issue with reading forcings requiring that the start time match the forcing time on init. That problem was fixed in MALI-Dev/E3SM#10 so we no longer need to start in the middle of the year to use the ISMIP6 forcing. To avoid confusion, I'm changing all tests to starrt on 2007-01-01. Also change all stream reference times to 2007-01-01. This is not necessary, because the default reference time of 0000-01-01 will yield the same results. But I'm changing it for explicitness. A minor conisderation is choosing a reference_time closer to the model clock time should provide a very small improvement to the cost of timekeeping operations related to i/o.
Previously, input files used as time-varying forcing failed to be read
at the initial model time. This commit forces input streams with an
input_interval set to a time duration to be forced to be read at the
model initial time. They are read in the same we these "forcing" files
are read during timestepping by using the most recent previous time
level from the input file.