Add halo update for calvingVelocity before calling li_apply_front_ablation_velocity from von_Mises_calving #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this using @matthewhoffman's tests in MPAS-Dev/compass#318. I had to change Results using |
Results from von Mises calving were not bit-for-bit across different numbers of processors. This fixes that issue. It is not apparent why this is necessary here, and why it is not necessary for eigencalving, so perhaps the issue is rooted in the fields used to calculate calvingVelocity in the von_Mises_calving routine.
trhille
force-pushed
the
add_calvingVelocity_halo_updates
branch
from
cf74863 to
80598aa
Compare
trhille
changed the title
matthewhoffman
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Thanks for rooting this out, @trhille . I don't see any problems and it passes all the COMPASS tests (as expected as none of the code changed is exercised by our primary COMPASS tests). Thanks for reporting the results of the calving tests. We'll have to dig into those other issues later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, von Mises calving results were not bit-for-bit across different numbers of processors. Adding a halo update for calvingVelocity before calling
li_apply_front_ablation_velocityfixes that issue. Eigencalving does not seem to require a halo update, which could mean that the issue is rooted in one or more of the fields that are used to calvingVelocity in thevon_Mises_calvingroutine. This also updates the description ofli_apply_front_ablation_velocityto include a note that this halo update may need to be performed before the call.