-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use rust edition 2024 #135
base: main
Are you sure you want to change the base?
Conversation
Warning Rate limit exceeded@mantricjavier has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe update modifies the Rust workspace’s Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Cargo.toml
(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests and Lints
Cargo.toml
[error] 1-1: Failed to parse manifest. Feature edition2024
is required but not stabilized in this version of Cargo (1.80.0). Consider trying a newer version of Cargo.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Validate schemas are up to date
@@ -15,7 +15,7 @@ authors = [ | |||
"Javier C <javier.m.costa@mantra.finance", | |||
] | |||
documentation = "https://docs.mantrachain.io/mantra-smart-contracts/mantra_dex" | |||
edition = "2021" | |||
edition = "2024" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical Issue: Unsupported Rust Edition 2024 in Current Cargo Version
The upgrade to edition = "2024"
is not supported by Cargo version 1.80.0 (as reflected by the pipeline failure). Please ensure that the build environment (CI and local tooling) uses a Cargo version that supports the Rust 2024 edition (for example, by switching to an appropriate nightly or updating to a newer stable release). If updating the toolchain is not feasible, consider reverting to a stable edition until full support is available.
todo: revise formatting both locally and with the IDE |
Description and Motivation
Fixes #134
Related Issues
Checklist:
Update index.md
)just fmt
.just lint
.just schemas
.Summary by CodeRabbit