Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitReports Public Issue Submission #148

Closed
ghost opened this issue Aug 25, 2016 · 3 comments
Closed

GitReports Public Issue Submission #148

ghost opened this issue Aug 25, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 25, 2016

Submitter: Felix Salim
Code is breaking at

11:06:29.990 TypeError: document.getElementById(...) is null
<anonymous>marie.min.js:12
MarieSim.prototype.regSet()marie.min.js:13
p/<()marie.min.js:13
c()marie.min.js:1
j/<()marie.min.js:1
g/</a[b]()marie.min.js:1
c()marie.min.js:1
j/<()marie.min.js:1
g/</a[b]()marie.min.js:1
c()marie.min.js:1
j/<()marie.min.js:1
g/</a[b]()marie.min.js:1
MarieSim.prototype.microStep()marie.min.js:13
MarieSim.prototype.step()marie.min.js:13
y()marie.min.js:12
<anonymous>marie.min.js:12
1marie.min.js:12:29200
@ghost ghost added the public label Aug 25, 2016
@ericjiang97
Copy link
Member

ericjiang97 commented Aug 31, 2016

It's @RavenKelder being a noob, he referenced a cell outside the memory address bound,tries updating memory view.

need to handle this error in a future update.

@auroranil
Copy link
Member

Here is a code snippet that replicates the problem.

JumpI X
X, DEC 4096

The literal 4096 is an out-of-bounds literal, but the compiler can not detect that because a label is being used. Using a label means that we have to detect if the JumpI instruction will move the program counter outside the boundaries of the memory (and raise an error when it does happen).

auroranil added a commit to auroranil/MARIE.js that referenced this issue Sep 5, 2016
auroranil added a commit that referenced this issue Sep 5, 2016
@ericjiang97
Copy link
Member

Negative Values still break.

Example Code:

Load X
Subt one
Store X
LoadI X

X, DEC 0
one, DEC 1

@ericjiang97 ericjiang97 reopened this Sep 6, 2016
@ericjiang97 ericjiang97 self-assigned this Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants