Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TTL for receivables scan, to ensure if there is no response that the next scan can occur #740

Open
kauri-hero opened this issue Aug 21, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kauri-hero
Copy link

kauri-hero commented Aug 21, 2023

This card is currently blocked by #676 and #744. Read more down here in the comment.

This may be a continuation of card #611

'Scan already in progress' Error appears for receivables scans of the blockchain - overall it appears that if there was no response from a receivables scan, there is no time-out.

Need to implement a TTL for receivables scan, and if there is a timeout, then the next scan can be attempted.

"The code isn't observing any blockchain service timeout"

@kauri-hero kauri-hero added the bug Something isn't working label Aug 21, 2023
@dnwiebe
Copy link

dnwiebe commented Aug 27, 2023

DANGER: Make sure you handle the situation where you send Request 1 and time out and give up, then send Request 2, then receive Response 1 (hey--it wasn't dead after all!), then receive Response 2. If you process both Response 1 and Response 2, you'll record duplicate payments. You have to reject one of them.

Dan has some ideas about this. If you can talk to him, do so; if you can't, think about keeping track of what the start block was when you send each request, and using it to tell whether an incoming response is unique or overlapping.

@bertllll bertllll self-assigned this Sep 4, 2023
@bertllll
Copy link

bertllll commented Sep 5, 2023

If we get started to haunt the objectives of this card now, we might bring more difficulties into our already tough position. See the newly created card #744 in case you're seeking for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Status: Backlog
Development

No branches or pull requests

3 participants