-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We're Falling Behind! #676
Comments
error[E0512]: cannot transmute between types of different sizes, or dependently-sized types |
For the rust-web3/json-rpc follow-ups after this card, I recommend we consider adopting https://github.com/alloy-rs (the planned successor to https://github.com/ethers-rs). The determining factor is if we think alloy-rs is ready for use. The other choice to evaluate is https://github.com/ethers-rs. I think we would prefer to do a single migration instead of one from rust-web3 to ethers-rs and another from ethers-rs to alloy-rs. The benefits of alloy-rs include improved Rust datatypes (e.g. uint256) perhaps even native flavors; Solidity macros; Flexible http transports; async/await; hardware wallets and other hardware keys for signing transactions. |
There is of course our dependence on old versions of actix and Tokio; but perhaps more urgent is the fact that Rust is moving on without us. The current Rust version at the time of this writing is 1.67.1, but we're stuck at 1.63.0, because we can't build with anything higher.
This is tolerable now, but eventually it will wedge us into a corner we can't escape from. We need to keep up with the advancing versions of Rust.
Determine what has to be done to:
async
/await
feature of Rustactix
andtokio
.wait()
on futures and blocking Actors from proceedingWrite cards to describe this work. Once the work is done, we should modify
Node/.github/workflows/ci_matrix.yml
so that the Rust toolchain is no longer fixed at 1.63.1, but is always the latest stable version.The text was updated successfully, but these errors were encountered: