GH-606: Address PR feedback

MASQ-Project · Oct 22, 2024 · 7c9b69d · 7c9b69d
1 parent 382f0de
commit 7c9b69d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs b/node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs
@@ -1060,9 +1060,11 @@ mod tests {
     #[test]
     fn blockchain_interface_retrieve_transactions_start_and_end_blocks_can_be_latest() {
         let port = find_free_port();
-        let _test_server = TestServer::start (port, vec![
-            br#"[{"jsonrpc":"2.0","id":1,"result":"error"},{"jsonrpc":"2.0","id":2,"result":[{"address":"0xcd6c588e005032dd882cd43bf53a32129be81302","blockHash":"0x1a24b9169cbaec3f6effa1f600b70c7ab9e8e86db44062b49132a4415d26732a","data":"0x0000000000000000000000000000000000000000000000000010000000000000","logIndex":"0x0","removed":false,"topics":["0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef","0x0000000000000000000000003f69f9efd4f2592fd70be8c32ecd9dce71c472fc","0x000000000000000000000000adc1853c7859369639eb414b6342b36288fe6092"],"transactionHash":"0x955cec6ac4f832911ab894ce16aa22c3003f46deff3f7165b32700d2f5ff0681","transactionIndex":"0x0"}]}]"#.to_vec()
-        ]);
+        let contains_error_causing_to_pick_fallback_value = br#"[{"jsonrpc":"2.0","id":1,"result":"error"},{"jsonrpc":"2.0","id":2,"result":[{"address":"0xcd6c588e005032dd882cd43bf53a32129be81302","blockHash":"0x1a24b9169cbaec3f6effa1f600b70c7ab9e8e86db44062b49132a4415d26732a","data":"0x0000000000000000000000000000000000000000000000000010000000000000","logIndex":"0x0","removed":false,"topics":["0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef","0x0000000000000000000000003f69f9efd4f2592fd70be8c32ecd9dce71c472fc","0x000000000000000000000000adc1853c7859369639eb414b6342b36288fe6092"],"transactionHash":"0x955cec6ac4f832911ab894ce16aa22c3003f46deff3f7165b32700d2f5ff0681","transactionIndex":"0x0"}]}]"#;
+        let _test_server = TestServer::start(
+            port,
+            vec![contains_error_causing_to_pick_fallback_value.to_vec()],
+        );
         let (event_loop_handle, transport) = Http::with_max_parallel(
             &format!("http://{}:{}", &Ipv4Addr::LOCALHOST, port),
             REQUESTS_IN_PARALLEL,

diff --git a/node/src/node_configurator/configurator.rs b/node/src/node_configurator/configurator.rs
@@ -2133,7 +2133,7 @@ mod tests {
     #[case("nOnE")]
     #[case("NoNe")]
     #[case("NONE")]
-    fn handle_set_configuration_accepts_none_to_unset_start_block(#[case] cfgValue: &str) {
+    fn handle_set_configuration_accepts_none_to_unset_start_block(#[case] cfg_value: &str) {
         init_test_logging();
         let test_name = "handle_set_configuration_accepts_none_to_unset_start_block";
         let set_start_block_params_arc = Arc::new(Mutex::new(vec![]));
@@ -2148,7 +2148,7 @@ mod tests {
         subject_addr.try_send(BindMessage { peer_actors }).unwrap();
         let msg = UiSetConfigurationRequest {
             name: "start-block".to_string(),
-            value: cfgValue.to_string(),
+            value: cfg_value.to_string(),
         };
         let context_id = 4444;