Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement default max-block-count value #552

Closed
kauri-hero opened this issue Nov 11, 2024 · 0 comments
Closed

Implement default max-block-count value #552

kauri-hero opened this issue Nov 11, 2024 · 0 comments
Assignees
@masqrauder
Labels
enhancement New feature or request

Comments

@kauri-hero
Copy link
Contributor

kauri-hero commented Nov 11, 2024 •
edited by masqrauder
Loading

Most of the feedback from the RPC providers has indicated that not having a smaller max block count will be a regular timeout issue as the range of scans increases. This will occur if the user is offline for more that a few days.

Implement max_block_count value of 100,000 as default value.

if the RPC response provides another value, then the logic will handle adjusting for that anyways.

GH-606 has made good improvements with this aspect, allowing startBlock for new database to be brought in from head of chain.

This card will further reduce scanning issues in future for serving Nodes
@kauri-hero kauri-hero converted this from a draft issue Nov 11, 2024
@kauri-hero kauri-hero added the enhancement New feature or request label Nov 11, 2024
@kauri-hero kauri-hero moved this from 🆕 New to 🔖 Awaiting Development (Prioritized) in MASQ Node v2 Nov 17, 2024
@masqrauder masqrauder moved this from 🔖 Awaiting Development (Prioritized) to 🏗 Development In Progress in MASQ Node v2 Nov 19, 2024
@masqrauder masqrauder changed the title Implement default max-start-block value Implement default max-block-count value Nov 24, 2024
masqrauder added a commit that referenced this issue Dec 1, 2024
@masqrauder
GH-552: max_block_count defaults to 100_000
ec3fea4
masqrauder added a commit that referenced this issue Dec 1, 2024
@masqrauder
GH-552: max_block_count defaults to 100_000
175b0db
masqrauder added a commit that referenced this issue Dec 1, 2024
@masqrauder
GH-552: max_block_count defaults to 100_000
f17c2fb
masqrauder added a commit that referenced this issue Dec 1, 2024
@masqrauder
GH-552: max_block_count defaults to 100_000
9565ae3
masqrauder added a commit that referenced this issue Dec 3, 2024
@masqrauder
GH-552: max_block_count defaults to 100_000
9d41219
@kauri-hero kauri-hero mentioned this issue Dec 8, 2024
Merged
@kauri-hero kauri-hero moved this from 🏗 Development In Progress to 👀 Review + QA in Progress in MASQ Node v2 Dec 8, 2024
masqrauder added a commit that referenced this issue Dec 13, 2024
@masqrauder
GH-552: Cleanup migration tests
15b7253
masqrauder added a commit that referenced this issue Dec 16, 2024
@masqrauder
GH-552: Bump macos target to macos-13
e6b27f9
kauri-hero pushed a commit that referenced this issue Dec 17, 2024
@masqrauder
GH-552: max_block_count defaults to 100_000 (#558)
b8e704a 
* GH-552: max_block_count defaults to 100_000

* GH-552: Cleanup migration tests

* GH-552: Bump macos target to macos-13
@github-project-automation github-project-automation bot moved this from 👀 Review + QA in Progress to ✅ Done in MASQ Node v2 Dec 17, 2024
masqrauder added a commit that referenced this issue Jan 19, 2025
@masqrauder
GH-552: Eliminate extra block increment
a8b8ec9
masqrauder added a commit that referenced this issue Jan 19, 2025
@masqrauder
GH-552: Eliminate extra block increment
29c1ba0
@masqrauder masqrauder mentioned this issue Jan 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masqrauder masqrauder

Labels
enhancement New feature or request
Projects
MASQ Node v2
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kauri-hero @masqrauder