GH-692: Allow UI to configure --min-hops during runtime #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new SetConfigurationMessage
…s name inside ConfigurationChange
…s name inside ConfigurationChange
…rator/configurator.rs
…cause it's a dead code
…hops_database_issue
dnwiebe
reviewed
Aug 2, 2023
dnwiebe
reviewed
Aug 9, 2023
dnwiebe
reviewed
Aug 11, 2023
dnwiebe
reviewed
Aug 14, 2023
dnwiebe
approved these changes
Aug 25, 2023
* GH-692: add the public constant DEFAULT_TRANSACT_TIMEOUT_MILLIS for the production code * GH-692: add another constant for the tests * GH-692: reduce total number of nodes for the min hops data routing test * GH-692: change the comment for the multinode test * GH-692: replace the constant for db_patch_size and use the different name everywhere * GH-692: put code back for NewPasswordMessage * GH-692: minor changes * GH-692: add error logging when the UiSetConfigurationRequest causes an error * GH-692: test fix and remove todo * GH-692: fix test set_configuration_command_throws_err_for_invalid_arg * GH-692: remove UpdateNewPassword variant * GH-692: add better error msg in case the assert statement fails
dnwiebe
approved these changes
Aug 28, 2023
dnwiebe
approved these changes
Sep 13, 2023
| @@ -63,11 +63,15 @@ const SET_CONFIGURATION_ABOUT: &str = | |||
| const START_BLOCK_HELP: &str = | |||
| "Ordinal number of the Ethereum block where scanning for transactions will start."; | |||
|
|
|||
| pub fn set_configurationify<'a>(shared_schema_arg: Arg<'a, 'a>) -> Arg<'a, 'a> { | |||
| shared_schema_arg.takes_value(true).required(false) | |||
There was a problem hiding this comment.
I don't think the .required(false) hurts anything, but I also think it's not necessary.
There was a problem hiding this comment.
I've removed it. 👍
dnwiebe
approved these changes
Sep 13, 2023
dnwiebe
approved these changes
Sep 18, 2023
dnwiebe
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.