-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-524: Disable entry_dns
#526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entry_dns
dnwiebe
approved these changes
Sep 27, 2024
utkarshg6
added a commit
that referenced
this pull request
Jan 6, 2025
* GH-813: Correctly parse max block range error message (#531) * GH-500: Adding Base chains (#510) * GH-500: ready for an urged live test * GH-500: probably finished the deployment of Base, let's get the QA going * GH-500: removed an eprintln! * GH-500: version changed to 0.8.1 --------- Co-authored-by: Bert <Bert@Bert.com> * update readme and tag v0.8.1 (#532) Signed-off-by: KauriHero <kaurihero@masq.ai> * GH-524: Disable `entry_dns` (#526) * GH-539: Don't Panic! (#540) * GH-539: Don't Panic * GH-539: remove commented out code * New Version: v0.8.2 (#542) * GH-744: Review-1 first lot of changes * GH-744: Review-1 - fixed more tests * GH-744: improved wildcard IP check * GH-744: removed unused imports * GH-744: fixed a bunch more comments from review 1 * GH-744: resolved more review comments * GH-744: started converting gas_price units from gwei to wei * GH-744: finish converting gas price from gwei to wei * GH-744: Formating & removed warnings * GH-744: Added TransactionFailed to TransactionReceiptResult * GH-606: Initialize start_block to none to use latest block (#374) * GH-606: Initialize start_block to none to use latest block * GH-606: Apply PR feedback changes * GH-606: Apply PR feedback changes * GH-606: Apply PR feedback changes * GH-606: Apply PR review 4 feedback changes * GH-606: Squashing commits - Save start_block_nbr if no msg but send as non-Option - Always commit - Reduce logging levels and simplify - Follow the Option naming pattern * GH-600: set_start_block only called in accountant/scanners/mod.rs * GH-606: PR Feedback - parameterize a test * GH-606: Address PR feedback * GH-606: Implement parameterized test without crate macro * GH-744: Migrated the guts of get_transaction_receipt_in_batch to process_transaction_receipts * GH-744: Moved submit_payables_in_batch to blockchain_interface * GH-744: removed test: blockchain_bridge_can_return_report_transaction_receipts_with_an_empty_vector * GH-744: Fixed a few more URGENCY comments * GH-744: cleanup & formatting * GH-744: add some TODOs as discussed on Wed and Thu * GH-744: handle_request_transaction_receipts chaged error to a DEBUG log * GH-744: handle_retrieve_transactions inbeded extract_max_block_count * GH-744: code refactor * GH-744: removed transaction_id from Agent * GH-744: Removed get_gas_price from submit_batch call * GH-744: logger is now a reference in send_payables_within_batch * GH-744: send_payables_within_batch web3_batch is now a reference * GH-744: sign_and_append_multiple_payments accounts is now a reference * GH-744 removed Blockchan_interface_mock * GH-744: Refactored all 4 test for send_payables_within_batch * GH-744: cleanup & formatting * GH-744: small fixs * GH-744: handle_normal_client_data detects wildcard IP & localhost with error * GH-744: Finished all urgent comments * GH-744: changed actions macos-12 to 13 * GH-744: increased sleep time for test provided_and_consumed_services_are_recorded_in_databases * GH-744: Fixed multinode tests * GH-744: Added start block +1 to handle_transaction_logs * GH-744: Fixed some tests * GH-744: Fixes from review 2 * GH-744: Fixed test debtors_are_credited_once_but_not_twice * GH-744: removed BlockNumber::Number * GH-744: Resolved TODOs * GH-744: First commit for review-3, fixed tests * GH-744: Refactored TxReceipt * GH-744: Refactored TxResponse * GH-744 moved & renamed blockchain_interface_utils.rs * GH-744: fixed test: dns_resolution_failure_for_wildcard_ip_with_real_nodes * GH-744: add review 4 changes * GH-744: add review 5 changes * GH-744: remove the map_err() * GH-744: migrate the logging code to a different function * GH-744: add review 6 changes --------- Signed-off-by: KauriHero <kaurihero@masq.ai> Co-authored-by: MASQrauder <60554948+masqrauder@users.noreply.github.com> Co-authored-by: Bert <65427484+bertllll@users.noreply.github.com> Co-authored-by: Bert <Bert@Bert.com> Co-authored-by: KauriHero <kaurihero@masq.ai> Co-authored-by: Syther007 <null.0.node@protonmail.com>
Syther007
added a commit
that referenced
this pull request
Feb 15, 2025
…456) * Added base comments * GH-744: removed .wait() from handle_request_balances_to_pay_payables * GH-744: added future return type to get_transaction_fee_balance * Fixed error mapping for .get_token_balance * GH-744: Fixed failing tests, all tests passing * GH-744: Added future return to ReportAccountsPayable * GH-744: Fixed more errors * GH-744: Added batch lifetime * Revert "GH-744: Added batch lifetime" This reverts commit ffe6b81. * GH-744: Fixed more errors * GH-744: small clean up * GH-744: Moved batch_payable_tools functions * GH-744: send_payables_within_batch accounts changed to Vec * GH-744: added blockchain_interface_slim * Added blockchain_interface_utils.js * GH-744: process_payments is working with futures * GH-744: Fixed a few more tests in blockchain_interface_utils * GH-744: Fixed test useing test_gas_limit_is_between_limits * Changed sign_transaction_data amount data type to u128 * GH-744 converted handle_retrieve_transactions return type to future * GH-744: Fixed some error with handle_retrieve_transactions * GH-744: update_start_block_message_works test works * GH-744: Added get_batch_web3 Mock * GH-744: Fixed test report_accounts_payable_returns_error_fetching_pending_nonce * GH-744: fixed test process_payments_returns_error_from_sending_batch * GH-744: fixed test handle_report_accounts_payable_transmits_eleventh_hour_error_back_to_accountant * GH-744: Edited test handle_report_accounts_payable_transacts_and_sends_finished_payments_back_to_accountant * GH-744: updated test handle_report_accounts_payable_transacts_and_sends_finished_payments_back_to_accountant * GH-744: FIxed test handle_retrieve_transactions_sends_received_payments_back_to_accountant * GH-744: Update to test processing_of_received_payments_continues_even_if_no_payments_are_detected * GH-744: Added Future return type to sign_transaction * GH-744: Added Future return to sign_and_append_payment * GH-744: sign_and_append_multiple_payments returns futures * GH-744: Fixed more test errors * GH-744: Fixed Lifetime issues * GH-744: fixed some tests * GH-744: added new test: sign_transaction_just_works * GH-744: cleaned up sign_transaction * GH-744: Added tests sign_and_append_payment_just_works, sign_and_append_payment_fails_on_badly_prepared_consuming_wallet_without_secret * GH-744: Warning clean up * GH-744: Cleanup & add todos * GH-744: removed Batch_web3 * GH-744: Changes after merge * GH-744: Merging Master, code is compiling * GH-744: Removed the generics from BlockchainInterface * GH-744: added get_service_fee_balance to Blockchain_interface * GH-744: Improved merge of retrieve_transactions * GH-744: retrieve_transactions test are all passing * GH-744: Trying to fix test in BlockChainBridge * GH-744: working on merging master * GH-744: added testsign_and_append_multiple_payments_works * GH-744: added test send_transaction_works * GH-744: send_transaction_2() is working fine on Utkarsh's machine * GH-744: fixed a few blockchain interface tests * GH-744: add new tests for sign_and_append_payment() * GH-744: Debugging Connection reset transport error * GH-744: Migrated MBCSBuilder to masq_lib, fixed two tests * GH-744: fixed alot of test within blockchain_interface_utils * GH-744: Added some tmp tests * GH-744: Removed futures from send_and_append_multiple_payments function stack * GH-744: Fixed a bunch of test for blockchain_interface_utils * GH-744: added two tested for send_payables * GH-744: all tests passing on file blockchain_interface_utils * GH-744: added new test process_payments_works * GH-744: Finished tests for process_payments * GH-744: added two tested for handle_outbound_payments_instructions * GH-744: Migrated get_transaction_fee_balance to blockchain_interface_utils * GH-744: migrated get_token_balance to blockchain_interface_util * GH-744: build_blockchain_agent now returns a Future * GH-744: refactored build_blockchain_agent * GH-744: Fixed formatting * GH-744: Fixed all test on blockchain_interface_web3/mod.rs * GH-744: Finished tests for handle_qualified_payable_msg * GH-744: added get_gast_price to build_blockchain_agent * GH-744: Removed persistent_config from build_blockchain_agent * GH-744: clean up of build_blockchain_agent * GH-744: refactored retrieve_transactions * GH-744: Fixed test handle_retrieve_transactions_sends_received_payments_back_to_accountant * GH-744: all tests working on blockchain_bridge.rs * GH-744: Cleaned up warnings * GH-744: Fixed a bunch of tests & clean up * GH-744: get_transaction_fee_balance now returns a future * GH-744: Migrated all functions back into lower_level_interface * GH-744: Fixed test: blockchain_bridge_is_constructed_with_correctly_functioning_connections * GH-744: fixed test: blockchain_interface_null_as_result_of_missing_blockchain_service_url * GH-744: removed blockchain_interface_null * GH-744: all tests within lower_level_interface are now working * GH-744: Moved get_transaction_receipt_batch to lower_level_interface * GH-744: Added tests for transaction_receipt_batch * GH-744: All tests passing on blockchain_birdge * GH-744: added fn get_transaction_logs to lower_level_interface * GH-744: added fn submit_payables_in_batch to lower_level_interface * GH-744: removed unnecessary functions from BlockchainInterface * GH-744: Todo clean up * GH-744: test: pending_transaction_is_registered_and_monitored_until_it_gets_confirmed_or_canceled is working * GH-744: clean up & all tests pasing * GH-744: cleanup of more todos * GH-744: Compiling after merge * GH-744: all but 1 tests are passing after merge * GH-744: Fixed pending_transaction_is_registered_and_monitored_until_it_gets_confirmed_or_canceled again * GH-744: Removed all warnings * GH-744: Formatting * GH-744: fixed all clippys warnings * GH-744: multinode tests running, but failing on MBCS * GH-744 fixed more multinode tests * GH-744: Added check for wildcard ip inside neighborhood * GH-744: Fixed all multinode intergration tests * GH-744: All tests are passing! * GH-744: fixed test send_payables_within_batch_fails_on_submit_batch_call for windows * GH-744: fixed handle_scan_future tests * GH-744: Added a fallback blockchain_service_url * GH-744: changes for self review * GH-744: Removed gas_price_result from tests * GH-744: Formatting * GH-744: Prepare for merge (#567) * GH-813: Correctly parse max block range error message (#531) * GH-500: Adding Base chains (#510) * GH-500: ready for an urged live test * GH-500: probably finished the deployment of Base, let's get the QA going * GH-500: removed an eprintln! * GH-500: version changed to 0.8.1 --------- Co-authored-by: Bert <Bert@Bert.com> * update readme and tag v0.8.1 (#532) Signed-off-by: KauriHero <kaurihero@masq.ai> * GH-524: Disable `entry_dns` (#526) * GH-539: Don't Panic! (#540) * GH-539: Don't Panic * GH-539: remove commented out code * New Version: v0.8.2 (#542) * GH-744: Review-1 first lot of changes * GH-744: Review-1 - fixed more tests * GH-744: improved wildcard IP check * GH-744: removed unused imports * GH-744: fixed a bunch more comments from review 1 * GH-744: resolved more review comments * GH-744: started converting gas_price units from gwei to wei * GH-744: finish converting gas price from gwei to wei * GH-744: Formating & removed warnings * GH-744: Added TransactionFailed to TransactionReceiptResult * GH-606: Initialize start_block to none to use latest block (#374) * GH-606: Initialize start_block to none to use latest block * GH-606: Apply PR feedback changes * GH-606: Apply PR feedback changes * GH-606: Apply PR feedback changes * GH-606: Apply PR review 4 feedback changes * GH-606: Squashing commits - Save start_block_nbr if no msg but send as non-Option - Always commit - Reduce logging levels and simplify - Follow the Option naming pattern * GH-600: set_start_block only called in accountant/scanners/mod.rs * GH-606: PR Feedback - parameterize a test * GH-606: Address PR feedback * GH-606: Implement parameterized test without crate macro * GH-744: Migrated the guts of get_transaction_receipt_in_batch to process_transaction_receipts * GH-744: Moved submit_payables_in_batch to blockchain_interface * GH-744: removed test: blockchain_bridge_can_return_report_transaction_receipts_with_an_empty_vector * GH-744: Fixed a few more URGENCY comments * GH-744: cleanup & formatting * GH-744: add some TODOs as discussed on Wed and Thu * GH-744: handle_request_transaction_receipts chaged error to a DEBUG log * GH-744: handle_retrieve_transactions inbeded extract_max_block_count * GH-744: code refactor * GH-744: removed transaction_id from Agent * GH-744: Removed get_gas_price from submit_batch call * GH-744: logger is now a reference in send_payables_within_batch * GH-744: send_payables_within_batch web3_batch is now a reference * GH-744: sign_and_append_multiple_payments accounts is now a reference * GH-744 removed Blockchan_interface_mock * GH-744: Refactored all 4 test for send_payables_within_batch * GH-744: cleanup & formatting * GH-744: small fixs * GH-744: handle_normal_client_data detects wildcard IP & localhost with error * GH-744: Finished all urgent comments * GH-744: changed actions macos-12 to 13 * GH-744: increased sleep time for test provided_and_consumed_services_are_recorded_in_databases * GH-744: Fixed multinode tests * GH-744: Added start block +1 to handle_transaction_logs * GH-744: Fixed some tests * GH-744: Fixes from review 2 * GH-744: Fixed test debtors_are_credited_once_but_not_twice * GH-744: removed BlockNumber::Number * GH-744: Resolved TODOs * GH-744: First commit for review-3, fixed tests * GH-744: Refactored TxReceipt * GH-744: Refactored TxResponse * GH-744 moved & renamed blockchain_interface_utils.rs * GH-744: fixed test: dns_resolution_failure_for_wildcard_ip_with_real_nodes * GH-744: add review 4 changes * GH-744: add review 5 changes * GH-744: remove the map_err() * GH-744: migrate the logging code to a different function * GH-744: add review 6 changes --------- Signed-off-by: KauriHero <kaurihero@masq.ai> Co-authored-by: MASQrauder <60554948+masqrauder@users.noreply.github.com> Co-authored-by: Bert <65427484+bertllll@users.noreply.github.com> Co-authored-by: Bert <Bert@Bert.com> Co-authored-by: KauriHero <kaurihero@masq.ai> Co-authored-by: Syther007 <null.0.node@protonmail.com> * GH-744: an attempt to fix test proxy_client_stream_reader_dies_when_client_stream_is_killed_integration * GH-744: add TODO in validate_ipv4 and make the unit tests passing * GH-744: Fixed test: debtors_are_credited_once_but_not_twice * GH-744: Fixed test: dns_resolution_failure_for_wildcard_ip_with_real_nodes * GH-744: fixed test blockchain_bridge_subs_factory_produces_proper_subs * GH-744: Added temp trace logs for Debugging * GH-744: Fixed Clippy * GH-744: changed the way we handle start_block updates * Revert "GH-744: changed the way we handle start_block updates" This reverts commit f3d8315. * GH-744: added more debugging for process_transaction_receipts * GH-744: debugging for get_transaction_receipt_in_batch * GH-744: added multi node test verify_blockchain_payments * GH-744: improved Test verify_blockchain_payments * GH-744: fixed get_transaction_receipt_in_batch * GH-744: Fixed start block Latest bug * GH-744 log cleanup * GH-744: fixes for QA Review * GH-744: improved is_running_in_integration_test as per review * GH-744: clean up * Gh-744: refactored retrieve_transactions for Start & End BlockNumber * GH-744: Fixes in regards to QA-Review-2 * GH-744: final review changes --------- Signed-off-by: KauriHero <kaurihero@masq.ai> Co-authored-by: Utkarsh Gupta <utkarshabhinav.torres@gmail.com> Co-authored-by: Utkarsh Gupta <32920299+utkarshg6@users.noreply.github.com> Co-authored-by: MASQrauder <60554948+masqrauder@users.noreply.github.com> Co-authored-by: Bert <65427484+bertllll@users.noreply.github.com> Co-authored-by: Bert <Bert@Bert.com> Co-authored-by: KauriHero <kaurihero@masq.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #524