Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in t=1 storage constraints for rho ~= 1 #11

Closed
rdzman opened this issue Aug 20, 2019 · 1 comment
Closed

bug in t=1 storage constraints for rho ~= 1 #11

rdzman opened this issue Aug 20, 2019 · 1 comment
Assignees
@rdzman
Labels
bug

Comments

@rdzman
Copy link
Member

rdzman commented Aug 20, 2019

For period t = 1 only, the constraints on storage dispatch and base scenario energy bounds, (4.33)-(4.34) in the MOST manual, are currently implemented as though rho = 1, independent of the actual value of rho.

The difference is a subtle one, with the stored energy at t = 0 represented by mdi.Storage.InitialStorage for rho = 0 and by the bounds mdi.Storage.InitialStorage[Lower/Upper]Bound for rho = 1.
@rdzman rdzman added the bug label Aug 20, 2019
@rdzman rdzman self-assigned this Aug 20, 2019
rdzman added a commit that referenced this issue Aug 20, 2019
@rdzman
Add tests to catch bug with storage constraints for t=1, rho~=1.
83d5761 
Refs: #11
@rdzman
Copy link
Member Author

rdzman commented Aug 20, 2019

See also #9, which helped uncover this bug.

@rdzman rdzman mentioned this issue Aug 20, 2019
Closed
@rdzman rdzman closed this as completed in 69488fb Aug 20, 2019
@rdzman rdzman mentioned this issue Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdzman rdzman

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rdzman