Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version update 0.0.2: Python 3.11 support, testing module, minor bugfixes, added utilities #104

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

narlesky
Copy link
Member

@narlesky narlesky commented Nov 30, 2023

Closes #103
Closes #102
Addresses #53
Addresses #43 (via version upgrade for selenium dependency)

Updates

  • Includes version upgrades for almost all dependencies
  • Adds PyOpenSsl dependency
  • Moves scipy to optional dependency for the utils.filters module
  • Implements pyproject.toml for installation configuration
  • Updates test data used for assertions in testing modules
  • Updates handling of non-certification verification in use of requests (verify=False or verify=ssl.CERT_NONE)
  • Prefers 'html.parser' to 'lxml' and removes 'lxml' dependency for use of BeautifulSoup4

To-do

  • fix test_get_wcds_data test (WCDS)
  • fix test_download_watershed_file test (CNRCC)
  • fix test_get_water_year_data test (WCDS)
  • fix test_get_sites_from_list test (SacAlert)
  • fix test__get_forecast_csv test (CNRFC)
  • fix test_get_rating_curve (CNRFC)
  • fix test_get_forecast_csvdata (CNRFC)
  • fix test_get_ensemble_forecast (CNRFC)
  • fix test_get_ensemble_first_forecast_ordinate (CNRFC)

@narlesky narlesky marked this pull request as draft November 30, 2023 03:03
@narlesky narlesky added bug Something isn't working utilities supporting utilities design/architecture labels Nov 30, 2023
@narlesky narlesky force-pushed the py311 branch 2 times, most recently from d995708 to 5e0c97e Compare October 4, 2024 17:04
@narlesky narlesky requested a review from ohalexander November 26, 2024 18:18
@narlesky narlesky marked this pull request as ready for review November 26, 2024 18:18
@ohalexander
Copy link
Contributor

I got this error on my Windows machine
image

@ohalexander
Copy link
Contributor

Does the readme also need to be updated now?

@ohalexander
Copy link
Contributor

ohalexander commented Nov 26, 2024

Error running tests on both my Mac and Windows machine--
from pandas.compat import is_numpy_dev as _is_numpy_dev
image

@ohalexander
Copy link
Contributor

Ran the unittests on my Mac--
image

@ohalexander
Copy link
Contributor

On windows--
image
The first error i think i can solve, just need to add my credentials.

@narlesky
Copy link
Member Author

narlesky commented Dec 4, 2024

Ran the unittests on my Mac-- image

Thanks, that led me to making a few updates in the B120 table parsing. Should be resolved with de9cd1e

@ohalexander
Copy link
Contributor

Is lxml a dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design/architecture utilities supporting utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11 Support BUG: get_station_sensors produces empty list for each duration
2 participants