Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hangar Platform Support #258

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Hangar Platform Support #258

merged 8 commits into from
Sep 11, 2023

Conversation

darbyjack
Copy link
Member

No description provided.

@darbyjack darbyjack added the enhancement New feature or request label May 6, 2023
@darbyjack darbyjack changed the title Hangar Author Support Hangar Platform Support May 6, 2023
@darbyjack darbyjack requested a review from jacobsandersen May 6, 2023 19:40
jacobsandersen
jacobsandersen requested changes May 6, 2023
View reviewed changes
Copy link
Collaborator

@jacobsandersen jacobsandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can encapsulate the library's HangarClient into our own HangarClient so we don't have a DummyClient. Otherwise LGTM

@darbyjack darbyjack requested a review from jacobsandersen May 7, 2023 19:03
@darbyjack darbyjack merged commit aaa165b into master Sep 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsandersen jacobsandersen jacobsandersen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darbyjack @jacobsandersen