Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to "Start in tray" on start up #52

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Add the option to "Start in tray" on start up #52

merged 4 commits into from
Nov 15, 2022

Conversation

HotaruBlaze
Copy link
Contributor

@HotaruBlaze HotaruBlaze commented Nov 5, 2022

This PR simply adds a setting so when you start the program, it will either show the GUI like default, or have it start in the system tray.

This partly addresses #50, however I'm not sure how to handle auto starting on operating systems other than windows and this could be handled in its own PR, However this makes other solutions easier/cleaner due to not having to worry about a GUI always showing on startup.

Note: I also changed the naming of the AnimatedToggle's due to the naming being confusing, and the positioning of the code didn't match top to down.
As well as small changes to the positioning of the settings options as I discovered the positioning was slightly off due to an oversized box, so I made it more uniform and the same sized box,

BWdEY0XhKfGHbaXM


I also included a small commit that fixes dark's system tray text to be more readable, example of before and after is shown below.

Before:
wZ5GoZ1xGaZlDakH
After:
cweOBSjXfNfuO05W

@HotaruBlaze HotaruBlaze changed the base branch from main to development November 5, 2022 16:20
@HotaruBlaze HotaruBlaze marked this pull request as draft November 5, 2022 16:37
@HotaruBlaze HotaruBlaze changed the title Add the option to "Start in the system tray" on start up Add the option to "Start in tray" on start up Nov 5, 2022
@HotaruBlaze HotaruBlaze marked this pull request as ready for review November 5, 2022 16:53
@HotaruBlaze
Copy link
Contributor Author

The Temporary Draft was because I decided to tweak the name and didn't want to waste a commit on a small change while i rewrote the git commits.

It used to say "Start Minimized" however afterwards I felt like that could be confusing, so I changed it to reflect the system tray in the code and in the UI.

@Jenni32222
Copy link

Using your code gives me an error, how come you did not get this?

image

@HotaruBlaze
Copy link
Contributor Author

Ah damn it, figured it out, my check to prevent that was flawed, Will be fixed shortly!

@HotaruBlaze
Copy link
Contributor Author

@Jenni32222 That should fix it for ya 👍

@Jenni32222
Copy link

@Jenni32222 That should fix it for ya 👍

Indeed did the trick, thanks for the fast fix!

@HotaruBlaze
Copy link
Contributor Author

Had to do a resigning of my commits as my GPG keys got exposed by a bad commit on one of my public repo's. Shouldn't have broken anything though.

@MCMi460 MCMi460 merged commit 6aac805 into MCMi460:development Nov 15, 2022
@MCMi460
Copy link
Owner

MCMi460 commented Nov 15, 2022

Thank you again, @HotaruBlaze!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants