Implement Autostart settings (Windows & Linux Support only) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll do some preliminary testing for Windows and then merge. Sorry for the wait, and thank you so much for all of the work you've done on this project! |
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings support for auto starting NSO-RPC on system login.
This PR also includes a fix for my previous regex hotfix that turned out to crash due to missing checks, I've replaced it with a change originally provided from #55 with credit provided in the commit.
As noted above, this PR only adds support for Linux and Windows,
Linux support is provided via a user service file:
~/.local/share/systemd/user/NSO-RPC.serviceNote: the above service only exists if the service is enabled, we disable and delete the service file whenever a user disables it.