Skip to content

fix: wc dist overwrite #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idosal merged 3 commits into from
Aug 5, 2025
+77 −1
Merged

fix: wc dist overwrite #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b18f83
fix: wc dist overwrite
idosal Aug 5, 2025
4168f0d
fix
idosal Aug 5, 2025
577c91e
fix
idosal Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion sdks/typescript/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,18 @@
"@vitejs/plugin-react": "^4.0.0",
"esbuild": "^0.25.5",
"jsdom": "^22.0.0",
"rimraf": "^6.0.1",
"typescript": "^5.0.0",
"vite": "^5.0.0",
"vite-plugin-dts": "^3.6.0",
"vitest": "^1.0.0"
},
"scripts": {
"prepublishOnly": "pnpm run build",
"build": "pnpm run bundle:iframe && tsc && vite build && pnpm run build:wc",
"build": "pnpm run clean && pnpm run bundle:iframe && tsc && vite build && pnpm run build:wc",
"build:wc": "vite build --config vite.config.wc.ts",
"bundle:iframe": "node scripts/bundle-iframe.js",
"clean": "rimraf dist",
"dev": "pnpm run bundle:iframe && vite",
"test": "vitest run",
"test:watch": "vitest watch",
Expand Down
1 change: 1 addition & 0 deletions sdks/typescript/client/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export default defineConfig({
}) as any,
],
build: {
emptyOutDir: false,
lib: {
entry: path.resolve(__dirname, 'src/index.ts'),
name: 'McpUiClient',
Expand Down
1 change: 1 addition & 0 deletions sdks/typescript/client/vite.config.wc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import path from 'path';
export default defineConfig({
plugins: [react()],
build: {
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting emptyOutDir: false may lead to stale files accumulating in the dist directory over time. Consider adding a comment explaining why this is necessary and documenting any manual cleanup procedures required.

Suggested change
build: {
build: {
// NOTE: emptyOutDir is set to false to preserve files in the dist directory between builds.
// This may lead to stale files accumulating in dist over time.
// If you change the output file names or remove files, you must manually clean the dist directory.
// Consider running `rm -rf dist/*` before building, or ensure your deployment process handles cleanup.

Copilot uses AI. Check for mistakes.
emptyOutDir: false,
outDir: 'dist',
lib: {
entry: path.resolve(__dirname, 'src/components/UIResourceRendererWC.tsx'),
Expand Down