Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD Build Fix #133

Merged
merged 14 commits into from
Jul 11, 2024
Merged

RTD Build Fix #133

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
625c38f
reponame vs packagename fix
ljwoods2 May 24, 2024
3eca258
added test and tweaked version determination
ljwoods2 May 25, 2024
095032e
linting
ljwoods2 May 25, 2024
f6ba774
linting
ljwoods2 May 25, 2024
94dae28
linting
ljwoods2 May 25, 2024
ca6b6f5
debugging github actions- is pip installing into correct env within t…
ljwoods2 May 25, 2024
a68f84a
remove redundant tests
ljwoods2 May 25, 2024
ce02240
Merge branch 'main' into main
lilyminium May 27, 2024
f6f752b
Authors + Changelog + Removed unused import
ljwoods2 May 28, 2024
6b39bfa
Merge branch 'MDAnalysis:main' into main
ljwoods2 Jul 11, 2024
422cf5b
version change
ljwoods2 Jul 11, 2024
828c1b9
changelog
ljwoods2 Jul 11, 2024
1270523
undo forked changes
ljwoods2 Jul 11, 2024
c33600c
dynamic version
ljwoods2 Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ The rules for this file:

### Fixed
<!-- Bug fixes -->
- Updated mambaforge version in `readthedocs.yaml` (Issue #132, PR #133)
- Switched deprecated pkg_resources to use importlib (PR #122, Issue #121)
- Fixed pypi_check with lowercase (PR #118, Issue #112)
- Fixed ModuleNotFound after installation (Issue #113, PR #115)
Expand Down
2 changes: 1 addition & 1 deletion readthedocs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ version: 2
build:
os: ubuntu-22.04
tools:
python: "mambaforge-4.10"
python: "mambaforge-23.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @ljwoods2, 4.10 is quite old! I worry that old versions could continue to be problematic in the future though, until we reactively update the version in the pins, and doesn't help existing MDAKits. How about switching to mambaforge-latest so it stays up-to-date?


conda:
environment: docs/requirements.yaml
Loading