Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated intersphinx_mapping dictionary use #18

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 28, 2023

Current intersphinx_mapping use is deprecated, this switches to the new dict of tuples approach.

@lilyminium
Copy link
Member

Thanks for opening this @IAlibay!! Seeing as you mentioned #16 in MDAnalysis/cookiecutter-mdakit#83, does that mean this PR fixes #16?

@IAlibay
Copy link
Member Author

IAlibay commented Aug 28, 2023

@lilyminium not as far as I'm aware, they just look like two separate issues I just noticed the warning needed addressing in my emails.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #18 (0728772) into main (bf22738) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@IAlibay IAlibay requested a review from ianmkenney August 30, 2023 20:45
@ianmkenney
Copy link
Member

LGTM, thanks @IAlibay

@ianmkenney ianmkenney merged commit b6f50cb into main Aug 30, 2023
@IAlibay IAlibay deleted the fix-intersphinx-mapping branch August 30, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants