Fixing deployment action (#4954)

* update deployment action for latest releases of artifact download and upload

* exclude full deploy tests with py3.13

Author: IAlibay

.github/workflows/deploy.yaml

@@ -51,7 +51,7 @@ jobs:
           fetch-depth: 0
 
       - name: Build wheels
-        uses: pypa/cibuildwheel@v2.20.0
+        uses: pypa/cibuildwheel@v2.23.0
         with:
           package-dir: package
         env:
@@ -63,8 +63,9 @@ jobs:
         if: |
           (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/package')) ||
           (github.event_name == 'release' && github.event.action == 'published')
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
+          name: wheel-${{ matrix.buildplat[0] }}-${{ matrix.python }}
           path: wheelhouse/*.whl
           retention-days: 7
 
@@ -88,8 +89,9 @@ jobs:
         if: |
           (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/package')) ||
           (github.event_name == 'release' && github.event.action == 'published')
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
+          name: sdist
           path: package/dist/*.tar.gz
           retention-days: 7
 
@@ -113,8 +115,9 @@ jobs:
         if: |
           (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/package')) ||
           (github.event_name == 'release' && github.event.action == 'published')
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
+          name: sdist_tests
           path: testsuite/dist/*.tar.gz
           retention-days: 7
 
@@ -131,18 +134,18 @@ jobs:
     runs-on: ubuntu-latest
     needs: [build_wheels, build_sdist, build_sdist_tests]
     steps:
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: artifact
           path: dist
+          merge-multiple: true
 
       - name: move_test_dist
         run: |
           mkdir -p testsuite/dist
           mv dist/mdanalysistests-* testsuite/dist
 
       - name: upload_source_and_wheels
-        uses: pypa/gh-action-pypi-publish@v1.11.0
+        uses: pypa/gh-action-pypi-publish@v1.12.4
         with:
           skip_existing: true
           repository_url: https://test.pypi.org/legacy/
@@ -160,18 +163,18 @@ jobs:
     runs-on: ubuntu-latest
     needs: [build_wheels, build_sdist, build_sdist_tests]
     steps:
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: artifact
           path: dist
+          merge-multiple: true
 
       - name: move_test_dist
         run: |
           mkdir -p testsuite/dist
           mv dist/mdanalysistests-* testsuite/dist
 
       - name: upload_tests
-        uses: pypa/gh-action-pypi-publish@v1.11.0
+        uses: pypa/gh-action-pypi-publish@v1.12.4
         with:
           packages_dir: testsuite/dist
           skip_existing: true
@@ -190,18 +193,18 @@ jobs:
     runs-on: ubuntu-latest
     needs: [build_wheels, build_sdist, build_sdist_tests]
     steps:
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: artifact
           path: dist
+          merge-multiple: true
 
       - name: move_test_dist
         run: |
           mkdir -p testsuite/dist
           mv dist/mdanalysistests-* testsuite/dist
 
       - name: upload_source_and_wheels
-        uses: pypa/gh-action-pypi-publish@v1.11.0
+        uses: pypa/gh-action-pypi-publish@v1.12.4
 
   upload_pypi_mdanalysistests:
     if: |
@@ -216,18 +219,18 @@ jobs:
     runs-on: ubuntu-latest
     needs: [build_wheels, build_sdist, build_sdist_tests]
     steps:
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: artifact
           path: dist
+          merge-multiple: true
 
       - name: move_test_dist
         run: |
           mkdir -p testsuite/dist
           mv dist/mdanalysistests-* testsuite/dist
 
       - name: upload_tests
-        uses: pypa/gh-action-pypi-publish@v1.11.0
+        uses: pypa/gh-action-pypi-publish@v1.12.4
         with:
           packages_dir: testsuite/dist
 
@@ -249,6 +252,9 @@ jobs:
           # Multiple deps don't like windows
           - os: windows-latest
             type: "FULL"
+          # Chemfiles won't install over py3.13
+          - python-version: "3.13"
+            type: "FULL"
     env:
       MPLBACKEND: agg