Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 9, 2025

Fixes #4783

Changes made in this Pull Request:

PR Checklist

  • Issue raised/referenced?
  • Tests updated/added?
  • Documentation updated/added?
  • package/CHANGELOG file updated?
  • Is your name in package/AUTHORS? (If it is not, add it!)

Developers Certificate of Origin

I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.


📚 Documentation preview 📚: https://mdanalysis--4954.org.readthedocs.build/en/4954/

@IAlibay IAlibay requested review from RMeli and fiona-naughton March 9, 2025 20:48
@IAlibay IAlibay marked this pull request as ready for review March 9, 2025 20:56
@codecov
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (bd00f88) to head (ee99023).
Report is 26 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4954      +/-   ##
===========================================
- Coverage    93.68%   93.65%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21845    22911    +1066     
  Branches      3077     3077              
===========================================
+ Hits         20465    21458     +993     
- Misses         930     1003      +73     
  Partials       450      450              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay requested review from orbeckst and p-j-smith March 9, 2025 21:09
@IAlibay IAlibay mentioned this pull request Mar 9, 2025
Copy link
Contributor

@fiona-naughton fiona-naughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@IAlibay IAlibay merged commit 0eb54dd into develop Mar 10, 2025
23 of 24 checks passed
Abdulrahman-PROG pushed a commit to Abdulrahman-PROG/mdanalysis that referenced this pull request Apr 13, 2025
* update deployment action for latest releases of artifact download and upload

* exclude full deploy tests with py3.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.8.0 deployment] Artifact upload failure

4 participants