-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Timestep as argument for writers #2043
Labels
Component-Writers
deprecation
Deprecated functionality to give advance warning for API changes.
usability
Milestone
Comments
I am adding this to 0.19.0 – but this can be targeted to a 0.19.x later. |
orbeckst
added
the
deprecation
Deprecated functionality to give advance warning for API changes.
label
Aug 12, 2018
richardjgowers
added a commit
that referenced
this issue
Oct 16, 2018
identified which Writers can currently use a ts (lots don't anyway)
4 tasks
orbeckst
pushed a commit
that referenced
this issue
Apr 3, 2019
- identified which Writers can currently use a ts (lots don't anyway) - deprecated Timestep as argument to Writer.write - Update package/MDAnalysis/coordinates/base.py - Update package/MDAnalysis/coordinates/XYZ.py - Update package/MDAnalysis/coordinates/GRO.py - add test_writer_api.py - removed obsolete test
We might have missed the boat on deprecating to get rid of 1.0. So I think we should deprecate in 1.0 and remove in 2.0. |
richardjgowers
added a commit
that referenced
this issue
Jun 5, 2020
- identified which Writers can currently use a ts (lots don't anyway) - deprecated Timestep as argument to Writer.write - Update package/MDAnalysis/coordinates/base.py - Update package/MDAnalysis/coordinates/XYZ.py - Update package/MDAnalysis/coordinates/GRO.py - add test_writer_api.py - removed obsolete test
richardjgowers
added a commit
that referenced
this issue
Jun 6, 2020
- identified which Writers can currently use a ts (lots don't anyway) - deprecated Timestep as argument to Writer.write - Update package/MDAnalysis/coordinates/base.py - Update package/MDAnalysis/coordinates/XYZ.py - Update package/MDAnalysis/coordinates/GRO.py - add test_writer_api.py - removed obsolete test
richardjgowers
added a commit
that referenced
this issue
Jun 8, 2020
* deprecate Timestep argument to Writers (issue #2043) Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com> Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
@richardjgowers @IAlibay what is left over after merge of PR #2110? Close or re-target to later milestone. |
I think #2110 should have fixed all this now. I'll close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component-Writers
deprecation
Deprecated functionality to give advance warning for API changes.
usability
As discussed in #206 we want to streamline the trajectory writer interface so that
only accepts AtomGroup or Universe as
arg
but notTimestep
anymore. (We can't think of a good reason when we would have aTimestep
but not an AG.)base.Writer.write()
mdanalysis/package/MDAnalysis/coordinates/base.py
Line 2146 in 388346d
Timestep
Timestep
will raise aTypeError
TypeError
)The text was updated successfully, but these errors were encountered: