WIP, TST: remove gsd & add Python 2.7 to appveyor config #2093
Conversation
|
I guess that was a tad optimistic |
tylerjereddy
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2093 +/- ##
========================================
Coverage 89.41% 89.41%
========================================
Files 159 159
Lines 18737 18737
Branches 2698 2698
========================================
Hits 16753 16753
Misses 1381 1381
Partials 603 603Continue to review full report at Codecov.
|
| @@ -29,6 +29,10 @@ environment: | |||
| PYTHON_ARCH: 64 | |||
| MSVC_VERSION: "Visual Studio 10 Win64" | |||
|
|
|||
| - PYTHON_VERSION: 2.7 | |||
| PYTHON_ARCH: 64 | |||
| MSVC_VERSION: "Visual Studio 10 Win64" | |||
There was a problem hiding this comment.
what motivated this change? if we want to support Python 2.7 on Windows we need to use older compilers and enforce C89 standard in our C source files I think. Maybe more trouble than it is worth though.
There was a problem hiding this comment.
I was just playing spot the difference between the two builds and hoping it was a typo. I didn't realise we had fundamental problems like that.
|
Did we decide to drop 2.7 for windows? We are not going for the windows build with 2.7 on conda-forge |
|
@kain88-de it won't work atm as far as I know, if someone did a PR that fixed it then sure, so it's more a known issue than we've dropped 2.7 support on Windows |
|
We'd need to revert to C89 standard to get compilation working here so closing based on previous discussions. |
IIRC the need to "mock import"
gsdwas preventing us from building & testing MDAnalysis with Python 2.7 on Windows (gsdcould be built but not actually used in 3.6, but not even built in 2.7 I think).This follows up on #2090 to see if Appveyor is happy with Python 2.7 builds now.