-
Notifications
You must be signed in to change notification settings - Fork 725
Calc_dihedral docstring updated #3956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calc_dihedral docstring updated #3956
Conversation
Codecov ReportBase: 94.38% // Head: 94.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #3956 +/- ##
===========================================
- Coverage 94.38% 94.27% -0.12%
===========================================
Files 194 194
Lines 25248 25248
Branches 3493 3493
===========================================
- Hits 23831 23802 -29
- Misses 1368 1397 +29
Partials 49 49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Please address my comments.
Please also
- add yourself to AUTHORS
- add your GitHub handle to CHANGELOG for 2.4.0 at the end of
Lines 16 to 17 in 3712439
??/??/?? IAlibay, Luthaf, hmacdope, rafaelpap, jbarnoud, BFedder, aya9aladdin, jaclark5, jfennick, lilyminium
Thank you for the help, have made necessary changes |
Thank you @Hakarishirenai , I'll have a look again when the CI check have run. But it's looking very good at first glance. As a new contributor, please also introduce yourself on the developer mailing list (see https://www.mdanalysis.org/#participating for the link) and mention your work on this PR. It's important that we have an email address where we can reach you because of our ongoing effort to change the license of MDAnalysis. We will not merge this PR until we know how we can contact you in the future. |
Thank you for introducing yourself https://groups.google.com/g/mdnalysis-devel/c/CjIST5IkZyM/m/Xtcn3D_rAAAJ . I'll merge. |
Thank you for your first commit! 🚀 |
Fixes #3936
Changes made in this Pull Request:
PR Checklist