-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDKitConverter improvements #4082
RDKitConverter improvements #4082
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4082 +/- ##
===========================================
- Coverage 93.65% 93.59% -0.07%
===========================================
Files 14 192 +178
Lines 1104 25109 +24005
Branches 0 4050 +4050
===========================================
+ Hits 1034 23500 +22466
- Misses 70 1092 +1022
- Partials 0 517 +517
☔ View full report in Codecov by Sentry. |
de4e537
to
8486bcd
Compare
Linter Bot Results:Hi @cbouy! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cbouy ! these changes look sane to me. I'd be curious how this approach compares to the new rdDetermineBond functions, but I think that's a long conversation to be had elsewhere
Yes it would be nice to have it as an alternative bond-inferring solution as well, and try it on the benchmark that I had set up some time ago. Might give it a go someday |
Part of #3996
Changes made in this Pull Request:
MONATOMIC_CATION_CHARGES
andSTANDARDIZATION_REACTIONS
) out of the related functions to allow users fine tuning them if necessary.RunReactantInPlace
for the standardization reactions, which should result in a significant speed improvement as we don't need to use bespoke code to transfer atomic properties from the non-standardized mol to the standardized one.Ideally I need to run the benchmark again to make sure that their are no regression from these changes, and I'd also like to make a comparison between the develop branch and these changes as there should be a significant speed improvement from using
RunReactantInPlace
.PR Checklist
📚 Documentation preview 📚: https://readthedocs-preview--4082.org.readthedocs.build/en/4082/