-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add necessary commits for 2.4.3 #4102
Conversation
Fixes #4039 * Fixes DCD seeking for large (2Gb+) files.
cirrus failure is expected - I don't see a need to cherry pick the fix here (since we don't use it for release), unless folks think otherwise |
I guess we'll need to cherry pick the parmed fix here. |
:/ this is a bit of a difficult one, if we cherry-pick the parmed fix, do we then change the changelog on develop to reflect that it went in on 2.4.3? Or do we just do it here and leave it as-is? The alternative option is to pin the upper value of Parmed in tests & conda-forge? |
Note - it's a fix on a failing test, but it didn't require any change to the Parmed parser codes. |
Pinging @MDAnalysis/coredevs it'd be good to get a quick decision on the path forward here. |
if the parmed fix is possible via a conda-forge pin it might make sense to do 2.4.3 that way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the parmed fix thing does not require an increase in minor version then you can put it in here without problems (especially if it's just something in the tests).
As with anything else, we just need to retroactively change develop's CHANGELOG.
EDIT: and add yourself to the 2.4.3 authors list @IAlibay
Ok, given we need to update the author list anyways, I'll just cherry-pick the parmed test fix and separately change the changelog for |
Fixes #4015 * fix expected list of elements for Parmed PSF test
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## package-2.4.3 #4102 +/- ##
================================================
Coverage ? 93.67%
================================================
Files ? 14
Lines ? 1091
Branches ? 0
================================================
Hits ? 1022
Misses ? 69
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Spack updated: spack/spack#36541 |
Cherry picked commits for 2.4.3:
Commits to prepare for 2.4.3: