Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DEFs to cdef int constants #4246

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

hmacdope
Copy link
Member

@hmacdope hmacdope commented Aug 16, 2023

Fixes #4237

Changes made in this Pull Request:

  • Changes cython DEFs to be integer constants due to deprecation of DEF in cython 3.0+

PR Checklist

  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4246.org.readthedocs.build/en/4246/

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Linter Bot Results:

Hi @hmacdope! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@hmacdope hmacdope requested review from orbeckst, IAlibay and RMeli and removed request for orbeckst and IAlibay August 16, 2023 12:27
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (212bf03) 93.40% compared to head (849fd09) 93.41%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4246      +/-   ##
===========================================
+ Coverage    93.40%   93.41%   +0.01%     
===========================================
  Files          169      183      +14     
  Lines        22202    23307    +1105     
  Branches      4064     4064              
===========================================
+ Hits         20738    21773    +1035     
- Misses         948     1018      +70     
  Partials       516      516              

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay merged commit a14e98d into MDAnalysis:develop Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of DEF statement
2 participants