Skip to content

Conversation

@Dreamstick9
Copy link

@Dreamstick9 Dreamstick9 commented Nov 24, 2025

Fixes #3743

Changes made in this Pull Request:

  • Replaced deprecated assert_almost_equal and assert_array_almost_equal with assert_allclose in testsuite/MDAnalysisTests/coordinates/base.py.
  • Converted decimal precision to atol=10**(-decimal) and rtol=0 to maintain original test strictness.
  • Added contributor name to package/AUTHORS.

PR Checklist

  • Issue raised/referenced?
  • Tests updated/added?
  • Documentation updated/added?
  • package/CHANGELOG file updated?
  • Is your name in package/AUTHORS?

Documentation preview : https://mdanalysis--5156.org.readthedocs.build/en/5156/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.72%. Comparing base (5c11b50) to head (5b23f52).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5156   +/-   ##
========================================
  Coverage    92.72%   92.72%           
========================================
  Files          180      180           
  Lines        22457    22472   +15     
  Branches      3186     3188    +2     
========================================
+ Hits         20823    20837   +14     
  Misses        1177     1177           
- Partials       457      458    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marinegor marinegor self-assigned this Nov 25, 2025
@marinegor marinegor self-requested a review November 25, 2025 21:16
@marinegor marinegor removed their assignment Nov 25, 2025
@Dreamstick9
Copy link
Author

Hi! The Windows test failed in test_density.py with a MaybeEncodingError (unrelated to my changes). Could you please trigger a re-run?

@IAlibay
Copy link
Member

IAlibay commented Nov 30, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Dreamstick9 Dreamstick9 force-pushed the fix/replace-numpy-asserts branch from e89e29e to 26727b5 Compare November 30, 2025 17:29
@Dreamstick9 Dreamstick9 requested a review from IAlibay December 1, 2025 07:49
@Dreamstick9 Dreamstick9 closed this Dec 5, 2025
@Dreamstick9 Dreamstick9 reopened this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modernize testing code

3 participants