-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin pandas<2.1 and add cron trigger to CI #92
Conversation
Ok can confirm it's pandas 2.1 :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requirements.txt is missing
For completeness I also pinned in requirements.txt |
The cryptic RTD error
is due to how you have specify conda/mamba in the rtd config file. I just ran into this the other day in Becksteinlab/GromacsWrapper#258 and Becksteinlab/GromacsWrapper@756b8a8 Let me have a quick look. |
Let's see if just using mambaforge works while letting RTD figure out the rest. |
|
This built the docs https://readthedocs.org/projects/solvation-analysis/builds/21958960/ although I am now slightly puzzled because the package wasn't installed. Presumably, sphinx imported the source directly. Check that the docs look right. Then possibly try adding python:
install:
- method: pip
path: . if something needs to be done. |
There are problems on RTD, see https://readthedocs.org/projects/solvation-analysis/builds/21958960/ (last command)
|
@orbeckst is the RTD stuff resolved or persisting? If it's all good I can merge. |
RTD builds so the immediate problem is solved. The issue with plotly can probably be fixed in another PR — I don’t want to add it to the RTD dependencies because I haven’t seen it as a dependency elsewhere. That will require someone with more insight than me. |
RTD is happy https://solvation-analysis--92.org.readthedocs.build/en/92/tutorials/plotting_tutorial.html — no complaints about missing packages. |
Thanks for adding plotly, @IAlibay —- I should have looked more carefully at the other requirement files because it was listed elsewhere, I just overlooked it. |
temporarily addressing #93 and see MDAnalysis/MDAKits#67