-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inconsequential calls to fetchSession() #39
Remove inconsequential calls to fetchSession() #39
Conversation
a call to fetchSession returns a promise but nothing is being done with the returned promise and the fetchSession method doesn't seem to have any side effects that would be useful after the sync, pull, push, or changes calls on the db.
was failing if the event 'pouchdb-livefeed-error' hadn't yet been emitted. So we wait until the nextTick and then we can ensure we're not missing any events.
assumes we're using pouchdb-authentication, will cause error if we're not. see issue #33
@assemblethis This is looking good and removes some rather useless calls which should make it a bit lighter on the network in general, feel free to merge when you're done. Thanks! |
Thanks, maybe we should release a version 0.3.5 in a little bit. Let me run this latest through a few more manual tests though. |
All unit tests passed: PASS tests/testData.spec.js And manual tests too |
Published to npm as pouch-vue 0.3.5, thanks @assemblethis |
This is a PR for the issue I raised in #34. In the sync, pull, push, and changes functions, there is a call to fetchSession() that returns a promise but nothing is being done with the returned promise. The fetchSession() method doesn't seem to have any side effects that would be useful after the sync, pull, push, or changes calls on the db. It seems to be inconsequential code, so I suggest removing it with this PR.