Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return variance explained for all components #50

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

eurunuela
Copy link
Collaborator

This PR aims to give the necessary data to build a variance explained graph for the case when all possible components are kept.

This PR aims to give the necessary data to build a variance explained graph for the case when all possible components are kept.
@eurunuela eurunuela requested a review from tsalo February 25, 2022 09:01
@codecov-commenter
Copy link

Codecov Report

Merging #50 (019e0d5) into main (cf42a93) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   90.26%   90.30%   +0.03%     
==========================================
  Files           3        3              
  Lines         298      299       +1     
==========================================
+ Hits          269      270       +1     
  Misses         29       29              
Impacted Files Coverage Δ
mapca/mapca.py 86.95% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf42a93...019e0d5. Read the comment docs.

@eurunuela
Copy link
Collaborator Author

@tsalo could you have a look at this PR? #839 in tedana needs this PR to work.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this.

@eurunuela eurunuela merged commit 90ca567 into ME-ICA:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants