Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DueCredit #54

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Remove DueCredit #54

merged 1 commit into from
Jan 5, 2023

Conversation

eurunuela
Copy link
Collaborator

@eurunuela eurunuela commented Jan 5, 2023

This PR closes #53.

Follow-up work of adding BibTex citations should happen in #46.

@codecov-commenter
Copy link

Codecov Report

Base: 90.30% // Head: 90.26% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0a86057) compared to base (90ca567).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   90.30%   90.26%   -0.04%     
==========================================
  Files           3        3              
  Lines         299      298       -1     
==========================================
- Hits          270      269       -1     
  Misses         29       29              
Impacted Files Coverage Δ
mapca/__init__.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eurunuela eurunuela changed the title Remove DueCredit and use BibTex Remove DueCredit Jan 5, 2023
@eurunuela eurunuela requested a review from tsalo January 5, 2023 13:18
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like duecredit wasn't actually being used, so there are no specific citations to remove.

@eurunuela
Copy link
Collaborator Author

LGTM. It looks like duecredit wasn't actually being used, so there are no specific citations to remove.

That's right, but it was being imported by __init__.py, which is why I believe we could still see it when running tedana.

@eurunuela eurunuela merged commit 45837f9 into ME-ICA:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove DueCredit dependency
3 participants