Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pyproject.toml and deleted files that are no longer necessary #61

Merged
merged 10 commits into from
Sep 22, 2023

Conversation

eurunuela
Copy link
Collaborator

@eurunuela eurunuela commented Sep 22, 2023

Closes #60.

This PR changes:

  • Only use pyproject.toml for installation, dependencies, etc.
  • Removes files that are no longer necessary.
  • Makes Python 3.8 the minimum version.
  • Makes scikit-learn 1.2 the minimum version.
  • Updates the tests from 3.5-3.7 to 3.8-3.10.
  • Creates __about__.py.

@eurunuela eurunuela changed the title Updated project.toml and deleted files that are no longer necessary Updated pyproject.toml and deleted files that are no longer necessary Sep 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.48% ⚠️

Comparison is base (556d013) 95.43% compared to head (e95b78a) 90.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   95.43%   90.96%   -4.48%     
==========================================
  Files           3        3              
  Lines         307      310       +3     
  Branches        0       32      +32     
==========================================
- Hits          293      282      -11     
  Misses         14       14              
- Partials        0       14      +14     
Files Changed Coverage Δ
mapca/mapca.py 89.63% <ø> (-5.70%) ⬇️
mapca/__about__.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested anything, but the changes look good to me.

@eurunuela eurunuela merged commit e96ff1c into ME-ICA:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update package installation and minimum Python version
3 participants