Fixed Inappropriate Logical Expression

[fazledyn-or]

Details

While triaging your project, our bug fixing tool generated the following message(s)-

In file: ica_reclassify.py, method: ica_reclassify_workflow, a logical expression uses the identity operator. A new object is created inside the identity check operation and then used for matching identity. Since this is a distinct, new object, it will not match with anything else. As a result, the identity check will have a logical short circuit and the program may have unintended behavior. iCR suggested that the logical operation should be reviewed for correctness.

Example

Running the program below will give the output-

foo = []
print(foo is [])
print(foo == [])

False
True

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (2525ba3) to head (1347ef6).
Report is 61 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          26       26           
  Lines        3395     3395           
  Branches      619      619           
=======================================
  Hits         3040     3040           
  Misses        207      207           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[handwerkerd]

Thank you for noticing this!
@tsalo or @eurunuela could you also review?