-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve component plots #1045
Improve component plots #1045
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 26 26
Lines 3444 3444
Branches 622 616 -6
=======================================
Hits 3077 3077
Misses 213 213
Partials 154 154 ☔ View full report in Codecov by Sentry. |
Argh, tight_layout doesn't help the line plots, but using Basically, I just need to fix up the spacing between the different axes in the figure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better. One thing I noticed is that the presented slices vary by component. For example, for the three-echo integration test, here are the images for components 15 & 51. The axial slice numbers are different. This is not great because we really want to compare the component maps between components, but I don't see an obvious way to fix this within plot_stat_map
. Thoughts?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So that we remember this change, note that the presented slices may be different for each component in the opening comment for this PR.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sad to see the originals go - but happy with similarly oriented brains.
I'm of two minds about the "best slices" approach - because it is nice to flip between components and see how the structure changes in the same area....but I'm convinced enough that it is better to have a better grasp of the individual components.
I think, based on what I've seen, that there is still enough information there to identify good/bad components, and perhaps it can do even better. Not worth holding up the overall fix, and potentially it could even improve that process.
Closes #1042.
Changes proposed in this pull request:
plot_stat_map
instead of identifying and plotting individual slices. This should address the potential orientation issues from Check orientation of brain/acquisition in figures #1042. It will also select the "best" slices for each component independently, so different components will have different slices rendered.