Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TST] Show logging output during integration tests #588

Merged
merged 3 commits into from
Aug 7, 2020
Merged

[TST] Show logging output during integration tests #588

merged 3 commits into from
Aug 7, 2020

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 1, 2020

Closes None.

Changes proposed in this pull request:

  • Show info-level logging output during integration tests.

@codecov
Copy link

codecov bot commented Aug 1, 2020 •
edited
Loading

Codecov Report

Merging #588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          26       26           
  Lines        1953     1953           
=======================================
  Hits         1825     1825           
  Misses        128      128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddaa4d5...a648cd7. Read the comment docs.

@tsalo tsalo requested review from jbteves and emdupre August 2, 2020 02:34
emdupre
emdupre reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should work, and it would make your logging level a little more explicit !

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@tsalo @emdupre
Apply suggestions from code review
a648cd7 
Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
jbteves
jbteves approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsalo !

@jbteves jbteves requested a review from emdupre August 7, 2020 15:43
@jbteves
Copy link
Collaborator

jbteves commented Aug 7, 2020

Oops sorry @emdupre didn't realize you'd already been asked to review already 🤦‍♂️

emdupre
emdupre approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me ! Thanks both !!

@tsalo tsalo merged commit 387db31 into ME-ICA:master Aug 7, 2020
@tsalo tsalo deleted the tst/logging branch August 7, 2020 17:26
@jbteves jbteves mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbteves jbteves jbteves approved these changes

@emdupre emdupre emdupre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsalo @jbteves @emdupre