-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Use README as long_desc #595
Conversation
Nonsense. It closes #472! |
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 26 26
Lines 1965 1965
=======================================
Hits 1838 1838
Misses 127 127 Continue to review full report at Codecov.
|
Does the README need to be in the manifest file or anything for this to work for the deployed package? |
I don't think so. I'm basing this idea off of Jupyter Book, and their manifest doesn't include their README ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to get rid of a todo. Thanks @emdupre !
Thanks, everyone ! Merging 🚀 |
Closes #472.
Changes proposed in this pull request: