-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Added link for tedana NeuroStars tag. #608
Conversation
Hey @aykhojandi, thanks for your contribution! Two quick things:
|
Got it, thanks. Made the necessary changes, let me know if something else
stands out as wrong. Best,
Arman
…On Tue, Sep 22, 2020 at 5:19 PM Joshua Teves ***@***.***> wrote:
Hey @aykhojandi <https://github.com/aykhojandi>, thanks for your
contribution! Two quick things:
1. Do you mind putting [DOC] at the start, rather than end, of your PR
2. Do you mind making this a Draft PR? Since we're unsure if it's
actually ready for review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#608 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJCW7UF33IR2N5FK66EBORTSHEIHTANCNFSM4RWIGLXA>
.
|
I would say something along the lines of "Please tag any posts about tedana usage with the |
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 26 26
Lines 1965 1965
=======================================
Hits 1838 1838
Misses 127 127 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor adjustments to link to NeuroStars with each of the tags.
Add 'tag' before tedana tag link Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Added proper formatting to tedana tag in support.rst Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
@aykhojandi there's just one more change I'd like to see, but this PR is looking great! Do you want to mark it ready for review? |
Better language clarifying tags Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Got it. I believe the last suggestion is now committed. I marked this ready for review. Let me know how else I can be of assistance. |
One related thing that would be really helpful is if you could also update the issue template ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM 👍 Thank you, @aykhojandi !
Oops, sorry I slipped on this. People without write access need to have their PRs merged for them, right? It's been a while. |
Yes 😸 If you also approve, I'll let you pull the trigger ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this, Arman! LGTM
@all-contributors please add @aykhojandi for documentation |
I've put up a pull request to add @aykhojandi! 🎉 |
Closes #593 .
Changes proposed in this pull request:
tedana
tag." instead of "...multi-echo
tag." ?(@jbteves and I were wondering this, given that we now want to point tedana-specific questions to the tedana tag).