Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Starts contribution page #624

Merged
merged 17 commits into from
Feb 2, 2021
Merged

[DOC] Starts contribution page #624

merged 17 commits into from
Feb 2, 2021

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented Nov 20, 2020

Closes #618 .

Changes proposed in this pull request Closes #618 :

  • Starts contributions.md with a sample sentence and previous funding sources
  • Links to README.md under the contributor table, which I suppose we could also move into this file.

Comments welcome, since we didn't have time to discuss much in previous meetings.

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #624 (91d9c96) into main (61af3f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          26       26           
  Lines        1965     1965           
=======================================
  Hits         1838     1838           
  Misses        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61af3f1...91d9c96. Read the comment docs.

contributions.md Outdated Show resolved Hide resolved
contributions.md Outdated
## Funding
Special thanks to the following sources of funding for `tedana`:
- National Institutes of Mental Health, Section on Functional Imaging Methods for supporting the 2019 `tedana` hackathon.
- National Institutes of Health for supporting the 2019 AFNI Code Convergence, where work in the 2019 `tedana` hackathon was continued.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- National Institutes of Health for supporting the 2019 AFNI Code Convergence, where work in the 2019 `tedana` hackathon was continued.
- National Institutes of Health for supporting the [2019 AFNI Code Convergence](https://codeconvergence.org), where work in the 2019 `tedana` hackathon was continued.

Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
contributions.md Outdated Show resolved Hide resolved
Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
@handwerkerd
Copy link
Member

I assume people can add their names & blurbs in alphabetical order?

@jbteves
Copy link
Collaborator Author

jbteves commented Nov 20, 2020

That was my unstated assumption, yes, @handwerkerd

@dowdlelt
Copy link
Collaborator

@jbteves Thinking something like this for my sentence:
Logan Dowdle helps folks get multi-echo data collection going on their scanners, tries to keep up with the increasing number of multi-echo papers, likes making figures that explain what tedana has done to the data and occasionally adds a new feature (with lots of help!).

contributions.md Outdated Show resolved Hide resolved
@eurunuela
Copy link
Collaborator

Thank you @jbteves and @handwerkerd for taking the lead on this.

Mine could say something like this:

Eneko Uruñuela helps with the development of dimensionality reduction and decomposition algorithms in tedana, with Principal Component Analysis to be more specific, and contributed to the development of the interactive reports.

jbteves and others added 2 commits November 23, 2020 09:09
Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
@jbteves
Copy link
Collaborator Author

jbteves commented Nov 23, 2020

@eurunuela double check me on 68c85dc

@eurunuela
Copy link
Collaborator

@eurunuela double check me on 68c85dc

Looks good, thanks!

contributions.md Outdated Show resolved Hide resolved
contributions.md Outdated
- Eneko Uruñuela helps with the development of dimensionality reduction and decomposition algorithms in tedana, with Principal Component Analysis to be more specific, and contributed to the development of the interactive reports.

## Funding
Special thanks to the following sources of funding for `tedana`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although Moz Open Leaders didn't provide direct funding, they did provide logistical support. Maybe we could expand funding to more general Funding and operational support and add Moz Open Leaders there ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. They supported @KirstieJane right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not exactly.. she had a Mozilla fellowship, but that didn't overlap with when she mentored this as a Moz Open Leaders project !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm terribly sorry, do you mind writing a short blurb for what they provided? I just don't know because I wasn't participating at that point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More generally: @KirstieJane, We're all adding a sentence or two that self-describes our contributions to tedana. I know your attention is focused elsewhere right now, but I'd like to be able to acknowledge your contributions here. Either make a suggestion to the PR or just put your self-description in a comment & someone else will add it to the text.

contributions.md Outdated Show resolved Hide resolved
@jbteves
Copy link
Collaborator Author

jbteves commented Nov 23, 2020

Alright, could each of you send me the website you'd like to link to? If you'd like for me to just hyperlink to your GitHub profile, I can do that, too. I'll make it a hyperlink on the bolded name @emdupre if you think that'll work.

@mvaziri
Copy link
Collaborator

mvaziri commented Nov 23, 2020

Thank you @jbteves and @handwerkerd doing this and including me. Mine could say:

Maryam Vaziri-Pashkam helps with the tedana documentation to make it easier to understand for beginners.

This is my website in case you decided to link to those:http://maryam-vaziri.com/

@javiergcas
Copy link
Collaborator

For me, it could be:
Javier Gonzalez-Castillo contributed to the development of dimensionality reduction and decomposition algorithms in tedana, as well as to the development of the interactive reports.

@handwerkerd
Copy link
Member

We can alway add people later, but it would be good to have the steering committee all represented when we merge this. @emdupre & @tsalo, if you have a. chance, could you write a few sentences of self-promotion in the near future?

@jbteves
Copy link
Collaborator Author

jbteves commented Jan 27, 2021

@tsalo and @emdupre just nudging you to ask if you could contribute a sentence or two about your contributions. I would be really pleased to include this in our fancy new upcoming release!

@emdupre
Copy link
Member

emdupre commented Jan 27, 2021

'Elizabeth DuPre initiated the tedana project in 2017, building on the ME-ICA codebase. She continued to develop the code and began actively creating the community structure as part of the fifth Mozilla Open Leaders cohort (mentored by Kirstie Whitaker). Since her time as interim BDFL, Elizabeth has been involved in most aspects of the project -- although she currently focuses primarily on improving tedana's integration with the broader neuroimaging ecosystem.'

contributions.md Outdated Show resolved Hide resolved
jbteves and others added 2 commits January 27, 2021 15:35
Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my info.

contributions.md Outdated Show resolved Hide resolved
contributions.md Outdated Show resolved Hide resolved
jbteves and others added 2 commits January 27, 2021 17:37
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
@jbteves
Copy link
Collaborator Author

jbteves commented Jan 27, 2021

@tsalo thank you but I think you're being modest!

Base automatically changed from master to main February 1, 2021 23:57
@tsalo
Copy link
Member

tsalo commented Feb 2, 2021

Thanks @jbteves! Is there anything else that needs to be done for this PR before it can be merged?

@jbteves
Copy link
Collaborator Author

jbteves commented Feb 2, 2021

Just need one more approval, that's all.

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have no comments. Thank you @jbteves

@jbteves
Copy link
Collaborator Author

jbteves commented Feb 2, 2021

Weird, for some reason everything kicked off correctly but OSF 504'd. I pushed an empty commit to re-trigger tests.

@jbteves jbteves merged commit 197513d into ME-ICA:main Feb 2, 2021
@jbteves jbteves deleted the add_contributions branch February 2, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add descriptive information for each contributors' contributions to tedana
8 participants