-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Starts contribution page #624
Conversation
Codecov Report
@@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 26 26
Lines 1965 1965
=======================================
Hits 1838 1838
Misses 127 127 Continue to review full report at Codecov.
|
contributions.md
Outdated
## Funding | ||
Special thanks to the following sources of funding for `tedana`: | ||
- National Institutes of Mental Health, Section on Functional Imaging Methods for supporting the 2019 `tedana` hackathon. | ||
- National Institutes of Health for supporting the 2019 AFNI Code Convergence, where work in the 2019 `tedana` hackathon was continued. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- National Institutes of Health for supporting the 2019 AFNI Code Convergence, where work in the 2019 `tedana` hackathon was continued. | |
- National Institutes of Health for supporting the [2019 AFNI Code Convergence](https://codeconvergence.org), where work in the 2019 `tedana` hackathon was continued. |
Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
I assume people can add their names & blurbs in alphabetical order? |
That was my unstated assumption, yes, @handwerkerd |
@jbteves Thinking something like this for my sentence: |
Thank you @jbteves and @handwerkerd for taking the lead on this. Mine could say something like this: Eneko Uruñuela helps with the development of dimensionality reduction and decomposition algorithms in tedana, with Principal Component Analysis to be more specific, and contributed to the development of the interactive reports. |
Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
@eurunuela double check me on 68c85dc |
Looks good, thanks! |
contributions.md
Outdated
- Eneko Uruñuela helps with the development of dimensionality reduction and decomposition algorithms in tedana, with Principal Component Analysis to be more specific, and contributed to the development of the interactive reports. | ||
|
||
## Funding | ||
Special thanks to the following sources of funding for `tedana`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although Moz Open Leaders didn't provide direct funding, they did provide logistical support. Maybe we could expand funding to more general Funding and operational support
and add Moz Open Leaders there ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. They supported @KirstieJane right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not exactly.. she had a Mozilla fellowship, but that didn't overlap with when she mentored this as a Moz Open Leaders project !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm terribly sorry, do you mind writing a short blurb for what they provided? I just don't know because I wasn't participating at that point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More generally: @KirstieJane, We're all adding a sentence or two that self-describes our contributions to tedana. I know your attention is focused elsewhere right now, but I'd like to be able to acknowledge your contributions here. Either make a suggestion to the PR or just put your self-description in a comment & someone else will add it to the text.
Alright, could each of you send me the website you'd like to link to? If you'd like for me to just hyperlink to your GitHub profile, I can do that, too. I'll make it a hyperlink on the bolded name @emdupre if you think that'll work. |
Thank you @jbteves and @handwerkerd doing this and including me. Mine could say: Maryam Vaziri-Pashkam helps with the tedana documentation to make it easier to understand for beginners. This is my website in case you decided to link to those:http://maryam-vaziri.com/ |
For me, it could be: |
'Elizabeth DuPre initiated the tedana project in 2017, building on the ME-ICA codebase. She continued to develop the code and began actively creating the community structure as part of the fifth Mozilla Open Leaders cohort (mentored by Kirstie Whitaker). Since her time as interim BDFL, Elizabeth has been involved in most aspects of the project -- although she currently focuses primarily on improving tedana's integration with the broader neuroimaging ecosystem.' |
Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my info.
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
@tsalo thank you but I think you're being modest! |
Thanks @jbteves! Is there anything else that needs to be done for this PR before it can be merged? |
Just need one more approval, that's all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I have no comments. Thank you @jbteves
Weird, for some reason everything kicked off correctly but OSF 504'd. I pushed an empty commit to re-trigger tests. |
Closes #618 .
Changes proposed in this pull request Closes #618 :
contributions.md
with a sample sentence and previous funding sourcesComments welcome, since we didn't have time to discuss much in previous meetings.