Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Log count of floored voxels in T2* estimation #656

Merged
merged 2 commits into from
Jan 22, 2021
Merged

[DOC] Log count of floored voxels in T2* estimation #656

merged 2 commits into from
Jan 22, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 21, 2021

Closes #589.

Changes proposed in this pull request:

  • Count number of voxels being floored in T2* estimation, then log it.

@codecov
Copy link

codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #656 (d48fb91) into master (dae9f20) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   93.59%   93.61%   +0.01%     
==========================================
  Files          26       26              
  Lines        1984     1989       +5     
==========================================
+ Hits         1857     1862       +5     
  Misses        127      127
Impacted Files Coverage Δ
tedana/decay.py 95.74% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae9f20...8c10657. Read the comment docs.

@tsalo tsalo requested review from dowdlelt and jbteves January 21, 2021 22:16
dowdlelt
dowdlelt previously approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@dowdlelt dowdlelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. I had forgotten about raising that issue and this is a clean fix.

jbteves
jbteves reviewed Jan 22, 2021
View reviewed changes
tedana/decay.py Outdated Show resolved Hide resolved
jbteves
jbteves previously approved these changes Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tsalo !

@tsalo @jbteves
Update tedana/decay.py
8c10657 
Co-authored-by: Joshua Teves <jbtevespro@gmail.com>
@tsalo tsalo dismissed stale reviews from jbteves and dowdlelt via 8c10657 January 22, 2021 22:02
jbteves
jbteves approved these changes Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad you liked the suggestion. Thanks again @tsalo !

@tsalo tsalo merged commit 6bfb6fa into ME-ICA:master Jan 22, 2021
@tsalo tsalo deleted the log-floor branch January 22, 2021 22:26
@jbteves jbteves mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbteves jbteves jbteves approved these changes

@dowdlelt dowdlelt dowdlelt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add count of floored T2* values in logging
3 participants
@tsalo @dowdlelt @jbteves