Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add warning about not using release-drafter releases to developer instructions #718

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 16, 2021

Closes None.

Changes proposed in this pull request:

  • Add a warning box about not directly releasing release-drafter release drafts (😆).

A screenshot:

image

@tsalo tsalo requested review from handwerkerd and jbteves April 16, 2021 15:13
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive amount of extra whitespace getting trimmed 😆

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #718 (0dc8c03) into main (7b329b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files          25       25           
  Lines        1782     1782           
=======================================
  Hits         1659     1659           
  Misses        123      123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b329b2...0dc8c03. Read the comment docs.

@tsalo tsalo requested a review from emdupre April 19, 2021 21:11
@tsalo
Copy link
Member Author

tsalo commented Apr 19, 2021

Impressive amount of extra whitespace getting trimmed 😆

LOL yeah I didn't even realize we had a trailing whitespace problem.

Once we merge this we'll be good to release, right?

@jbteves
Copy link
Collaborator

jbteves commented Apr 19, 2021

Correct! If you feel it's pressing I'll go ahead and release, but I figured this would be a better point to release from since it has the instructions updated.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM ! New release here we come !! 🚀

@tsalo tsalo merged commit 78e4378 into ME-ICA:main Apr 26, 2021
@tsalo tsalo deleted the release-info branch April 26, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants