-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Move logger management to new functions #750
Conversation
Codecov Report
@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 92.61% 92.69% +0.08%
==========================================
Files 27 27
Lines 2125 2121 -4
==========================================
- Hits 1968 1966 -2
+ Misses 157 155 -2
Continue to review full report at Codecov.
|
It's unnecessary now that we're using a single LGR for general logging.
The issue is that pytest's handler is different from our own.
The output logs look reasonable in the latest artifacts ! Just confirming that when running locally:
updates to
is that right ? Assuming so, is there anything specific you'd like feedback on here ? |
@emdupre yeah, that looks right! There's nothing in particular that I'm worried about, so any review of any part of it would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this cleans up quite a bit!
Closes #719.
Changes proposed in this pull request:
The changes to the loggers doesn't show up in the CI, because
pytest
's logging is different from the logging set up in the workflows... but it looks good when run locally! Here's a snippet of my Terminal output from a local run: