Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Improved walkthrough with GIFs #765

Closed
wants to merge 9 commits into from
Closed

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 25, 2021

Closes #690. Still a WIP.

https://tedana--765.org.readthedocs.build/en/765/multi-echo_walkthrough.html

The more I think about it, the more I wonder if maybe we should move things like the multi-echo walkthrough into a different location, like a Jupyter Book, with https://naturalistic-data.org as inspiration.

GIFs are going to take up a lot of space and bulk up our git repository, but I do think they're really helpful for learning about multi-echo fMRI.

Changes proposed in this pull request:

  • Add gifs to help readers build a more intuitive understanding of multi-echo denoising.

* Update gitignore

* New gifs and notebook.

* Improve gifs.

* More lovely figures.

* Reduce gifs for speed-testing.

* Start adding.

* Some more work.

* Update multi-echo_walkthrough.rst

* Update multi-echo_walkthrough.rst
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #765 (797b026) into main (7e1cf2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage   93.19%   93.19%           
=======================================
  Files          27       27           
  Lines        2204     2204           
=======================================
  Hits         2054     2054           
  Misses        150      150           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1cf2c...797b026. Read the comment docs.

@eurunuela
Copy link
Collaborator

I agree that a Jupyter Book would fit the walkthrough much better.

GIFs are definitely useful to understand the content, but I wonder if a dash app or an Observable notebook would be nicer. Folks would get to "learn by playing" with interactive plots.

@emdupre
Copy link
Member

emdupre commented Jul 26, 2021

I'd vote for "all of the above" if folks have time and interest !

Specifically on this point:

GIFs are going to take up a lot of space and bulk up our git repository, but I do think they're really helpful for learning about multi-echo fMRI.

Do we have to host the GIFs here ? Could we host them on e.g. OSF and just render them in the docs ? I've also successfully hosted animated SVGs as Gists in the past, which could be another option ?

@tsalo
Copy link
Member Author

tsalo commented Jul 28, 2021

Would it be difficult to set up the Jupyter book in another repo and just let folks add to it as they're willing/able?

Could we host them on e.g. OSF and just render them in the docs ?

That seems feasible. I'll try it out.

Comment on lines 50 to 51
.. image:: https://osf.io/m7aw3/
:alt: physics_signal_decay.png
Copy link
Member Author

@tsalo tsalo Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emdupre this doesn't seem to be working. Any ideas?

My local docs build:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just requested access to that OSF link to see what it includes !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should modify to the "render" link, e.g.
https://mfr.osf.io/render?url=https://osf.io/mx4ku/?direct%26mode=render%26action=download%26mode=render

But updating the url as appropriate !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... it seems like it should work, but it doesn't seem to help:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what's happening and (at least) two suggestions.
During the build process, Sphinx is trying to copy the files into the generated _build directory. Because these are embedded images on a web page, this process fails and results in what you're showing above. To resolve this, we could (in no particular order) :

  • Update those image tags to iframes, to embed the web pages
  • Fetch the relevant files using cURL or the OSF API during the documentation build process so they would exist appropriately in the _build directory.
  • Switch to another provider (or revert to GitHub) where we can access the files themselves.

Do you have a preference, @tsalo ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this.

Do you have a preference, @tsalo ?

I'm not sure. I'm leaning toward iframes for right now, but I also really want to try out the Jupyter Book idea, in which case the GIFs would be generated by, and rendered in, the notebooks.

@tsalo
Copy link
Member Author

tsalo commented Aug 20, 2021

I'm just going to close this in favor of the Jupyter Book. If that doesn't work out for some reason, I can reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine multi-echo fMRI walkthrough
3 participants