-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Add 3.10 unit test, compatibilities in setup.cfg #818
Conversation
In NiMARE trying out Python 3.10 failed. I don't even know what's happening here... Why would it freeze like that? |
It appears it was trying to download many copies of many packages... I'm not sure. I'm willing to wait a bit and simply push a blank commit to see if it is resolved in perhaps a month. |
It looks like v1.21.4 supports 3.10. |
It looks like SciPy 1.8 may now support Python 3.10. Worth confirming? https://docs.scipy.org/doc/scipy/release.1.8.0.html |
No dice. |
I think this might be worth another check. Can you update from main? |
Finally passes, now that we have 3.11! |
Codecov ReportBase: 93.30% // Head: 93.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 28 28
Lines 2345 2345
=======================================
Hits 2188 2188
Misses 157 157 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Closes #817 .
Changes proposed in this pull request: