Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] The rationale column of comptable gets updated when no manacc is given #855

Merged
merged 4 commits into from
Mar 15, 2022
Merged

[FIX] The rationale column of comptable gets updated when no manacc is given #855

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e9611f
Get manacc from Rica's ctab
eurunuela Mar 9, 2022
3efbea0
Fix linting errors
eurunuela Mar 9, 2022
33597cf
Update rationale column regardless of ctba
eurunuela Mar 9, 2022
4d9cccf
Change to empty string even on non-accepted components with NaNs
eurunuela Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tedana/workflows/tedana.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,8 @@ def tedana_workflow(
comptable, metric_metadata = selection.kundu_selection_v2(comptable, n_echos, n_vols)
else:
comptable = pd.read_table(ctab)
# Change rationale value of rows with NaN to empty strings
comptable.loc[comptable.rationale.isna(), "rationale"] = ""

if manacc is not None:
comptable, metric_metadata = selection.manual_selection(comptable, acc=manacc)
Expand Down