-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH, FIX] PCA variance enhancements and consistency improvements #877
[ENH, FIX] PCA variance enhancements and consistency improvements #877
Conversation
Codecov Report
@@ Coverage Diff @@
## main #877 +/- ##
==========================================
- Coverage 93.15% 93.09% -0.06%
==========================================
Files 27 27
Lines 2234 2245 +11
==========================================
+ Hits 2081 2090 +9
- Misses 153 155 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor typo, and one place where I'd prefer you use the word instead of the symbol because my brain keeps reading it as a bitwise and since this is code. Otherwise LGTM.
typo Co-authored-by: Joshua Teves <jbtevespro@gmail.com>
Co-authored-by: Joshua Teves <jbtevespro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @handwerkerd !
Closes #876.
Changes proposed in this pull request:
check_tedpca_value
to allow integers >=1 and added unit tests for valid and invalid integers.Notes:
varex_norm = varex / varex.sum()
for the pre-defined variance-explained option and also for the low-mem option. It usesvarex_norm = ppca.explained_variance_ratio_
for mdl, kic, & aic.decomposition/pca.py
andtedana.py
We can add another integration test for when a fixed integer number of components are predefined, but since that would non-trivially increase the duration of the tests, I didn't want to do that without some discussion. Adding direct tests forpca.py
and modularizingtedana.py
more would be a better approach, but well beyond the scope of this PR.