Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add F-T2 and F-S0 maps to verbose outputs #893

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Add F-T2 and F-S0 maps to verbose outputs #893

merged 4 commits into from
Nov 11, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 4, 2022

Closes #891.

Changes proposed in this pull request:

  • Add PCA and ICA F-statistic maps for the T2* and S0 models (for each component) to verbose outputs.

@tsalo tsalo added the enhancement issues describing possible enhancements to the project label Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 93.29% // Head: 93.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ca25678) compared to base (c7924b5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   93.29%   93.30%           
=======================================
  Files          28       28           
  Lines        2342     2345    +3     
=======================================
+ Hits         2185     2188    +3     
  Misses        157      157
Impacted Files Coverage Δ
tedana/metrics/collect.py 95.02% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo requested review from handwerkerd and jbteves November 7, 2022 18:54
jbteves
jbteves approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

handwerkerd
handwerkerd approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@handwerkerd handwerkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsalo tsalo merged commit 0879a94 into ME-ICA:main Nov 11, 2022
@tsalo
Copy link
Member Author

tsalo commented Nov 11, 2022

Thanks!

@tsalo tsalo deleted the narep branch November 11, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbteves jbteves jbteves approved these changes

@handwerkerd handwerkerd handwerkerd approved these changes

Assignees
No one assigned
Labels
enhancement issues describing possible enhancements to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save F_T2* and F_S0 maps
3 participants
@tsalo @handwerkerd @jbteves