logging MAPCA subsampling #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
==========================================
- Coverage 88.97% 88.91% -0.06%
==========================================
Files 27 27
Lines 3373 3375 +2
Branches 617 618 +1
==========================================
Hits 3001 3001
- Misses 226 227 +1
- Partials 146 147 +1
☔ View full report in Codecov by Sentry. |
|
LGTM! |
handwerkerd
added
enhancement
dowdlelt
approved these changes
Jun 13, 2023
|
@eurunuela If you're also ok with this, could you approve so that I can merge? |
eurunuela
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once ME-ICA/mapca#57 is merged into MAPCA, it will be possible for tedana to log the estimated subsampling value and several related parameters.
Changes proposed in this pull request:
desc-PCACrossComponent_metrics.jsonI decided to add a conditional statement to only log these new values if they exist. The alternative is, once the above PR is merged into MAPCA, we release a new version of MAPCA and then update the minimum MAPCA version allowed with tedana. I'd rather just merge for now and then we can delete the conditional in the same PR where the minimum version of MAPCA is increased.